From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Kent Gibson <warthog618@gmail.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH 1/2] gpio: sim: dispose of irq mappings before destroying the irq_sim domain
Date: Tue, 22 Aug 2023 15:12:04 +0300 [thread overview]
Message-ID: <ZOSmFGZHrLq3I+zF@smile.fi.intel.com> (raw)
In-Reply-To: <20230822075122.6900-1-brgl@bgdev.pl>
On Tue, Aug 22, 2023 at 09:51:21AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> If a GPIO simulator device is unbound with interrupts still requested,
> we will hit a use-after-free issue in __irq_domain_deactivate_irq(). The
> owner of the irq domain must dispose of all mappings before destroying
> the domain object.
...
> +static void gpio_sim_dispose_mappings(void *data)
> +{
> + struct gpio_sim_chip *chip = data;
> + unsigned int i, irq;
> +
> + for (i = 0; i < chip->gc.ngpio; i++) {
> + irq = irq_find_mapping(chip->irq_sim, i);
> + if (irq)
This duplicates check in the following call.
> + irq_dispose_mapping(irq);
> + }
> +}
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-22 12:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 7:51 [PATCH 1/2] gpio: sim: dispose of irq mappings before destroying the irq_sim domain Bartosz Golaszewski
2023-08-22 7:51 ` [PATCH 2/2] gpio: sim: pass the GPIO device's software node to irq domain Bartosz Golaszewski
2023-08-22 13:59 ` Andy Shevchenko
2023-08-22 12:12 ` Andy Shevchenko [this message]
2023-08-22 12:16 ` [PATCH 1/2] gpio: sim: dispose of irq mappings before destroying the irq_sim domain Bartosz Golaszewski
2023-08-22 12:24 ` Andy Shevchenko
2023-08-22 12:38 ` Bartosz Golaszewski
2023-08-22 12:46 ` Andy Shevchenko
2023-08-22 13:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOSmFGZHrLq3I+zF@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox