From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52500EE49A4 for ; Tue, 22 Aug 2023 12:12:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235596AbjHVMML (ORCPT ); Tue, 22 Aug 2023 08:12:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232943AbjHVMMK (ORCPT ); Tue, 22 Aug 2023 08:12:10 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 010D5193; Tue, 22 Aug 2023 05:12:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692706329; x=1724242329; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=bMNqRaTXKeMhSmYsxEJBGG9KPMjo7EzITadHa8MbaRQ=; b=mwKP9eQBpkfy6LXFVw0eAw3OvTFi8A5RqsxWoGU+/Nz2i6Y7/V7NSOEP aT9Qyxe9qCg+xJXScuADSxAkZ0wWitEBi3jgS2bfFNF5oGYpy09upq0mH vwGW/9u+Srt6j4dUyw9L57S6RWkd4CaPadrEBt3pKnLQgcnY10Lf/yPn2 SqTas2JV4q+BCfhK1Y+1ZsVVx8l5GvJR9Bpepan4b2qcb3CWgAisbuxyT 1JavzX3juWw1NECPnyeNyEItetoGLmIbN8XJKwjm8x+PmFVRD+YoGkXmx HLA+N30EWauUnTq/MS3/SLNmugK5BHTfXxogcZSJ8ILdK2s2SiFPIqn7+ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="371284424" X-IronPort-AV: E=Sophos;i="6.01,193,1684825200"; d="scan'208";a="371284424" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2023 05:12:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="739285939" X-IronPort-AV: E=Sophos;i="6.01,193,1684825200"; d="scan'208";a="739285939" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga007.fm.intel.com with ESMTP; 22 Aug 2023 05:12:05 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qYQEu-009akW-14; Tue, 22 Aug 2023 15:12:04 +0300 Date: Tue, 22 Aug 2023 15:12:04 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Linus Walleij , Kent Gibson , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH 1/2] gpio: sim: dispose of irq mappings before destroying the irq_sim domain Message-ID: References: <20230822075122.6900-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230822075122.6900-1-brgl@bgdev.pl> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 22, 2023 at 09:51:21AM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > If a GPIO simulator device is unbound with interrupts still requested, > we will hit a use-after-free issue in __irq_domain_deactivate_irq(). The > owner of the irq domain must dispose of all mappings before destroying > the domain object. ... > +static void gpio_sim_dispose_mappings(void *data) > +{ > + struct gpio_sim_chip *chip = data; > + unsigned int i, irq; > + > + for (i = 0; i < chip->gc.ngpio; i++) { > + irq = irq_find_mapping(chip->irq_sim, i); > + if (irq) This duplicates check in the following call. > + irq_dispose_mapping(irq); > + } > +} -- With Best Regards, Andy Shevchenko