From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yann Sionneau <ysionneau@kalrayinc.com>
Cc: Yann Sionneau <ysionneau@kalray.eu>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Julian Vetter <jvetter@kalrayinc.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] Currently if the SoC needs pinctrl to switch the SCL and SDA from the I2C function to GPI
Date: Tue, 22 Aug 2023 17:27:20 +0300 [thread overview]
Message-ID: <ZOTFyHzsOSvfzNjD@smile.fi.intel.com> (raw)
In-Reply-To: <b12f4f63-4504-e775-166d-9ea30dd97489@kalrayinc.com>
On Tue, Aug 22, 2023 at 04:15:25PM +0200, Yann Sionneau wrote:
> On 8/22/23 15:26, Andy Shevchenko wrote:
> > On Tue, Aug 22, 2023 at 03:11:23PM +0200, Yann Sionneau wrote:
...
> > You forgot my tag. Why?
> Woops sorry, I am not used to sending patches upstream. I didn't know I had
> to add the ack tag. Will do it!
Any tags, Acked-by, Reviewed-by, ...
> > Also I think this will generate more code and more noise in debug case.
> > So, I admit I gave a bad suggestion in previous round.
> Ah yes you are right in case of dbg+CONFIG_PINCTRL not set it will print
> both messages but just one is enough.
> >
> > Please, go for v3 with my tag (as v5).
> >
> Ok, I'll also add `i2c: designware: ` to $subject as Mika Westerberg
> suggested.
It seems that Subject was completely missing.
In the commit message it's a first line followed by a blank line.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-08-22 14:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 13:11 [PATCH v4] Currently if the SoC needs pinctrl to switch the SCL and SDA from the I2C function to GPI Yann Sionneau
2023-08-22 13:26 ` Andy Shevchenko
2023-08-22 13:35 ` Mika Westerberg
2023-08-22 14:15 ` Yann Sionneau
2023-08-22 14:27 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOTFyHzsOSvfzNjD@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jvetter@kalrayinc.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=ysionneau@kalray.eu \
--cc=ysionneau@kalrayinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox