From: Benjamin Poirier <bpoirier@nvidia.com>
To: "Björn Töpel" <bjorn@kernel.org>
Cc: "Shuah Khan" <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
"Björn Töpel" <bjorn@rivosinc.com>,
"Jonathan Toppins" <jtoppins@redhat.com>
Subject: Re: [PATCH] selftests: Keep symlinks, when possible
Date: Tue, 22 Aug 2023 11:49:50 -0400 [thread overview]
Message-ID: <ZOTZHhGLnQKOhITt@d3> (raw)
In-Reply-To: <20230822135837.280967-1-bjorn@kernel.org>
On 2023-08-22 15:58 +0200, Björn Töpel wrote:
> From: Björn Töpel <bjorn@rivosinc.com>
>
> When kselftest is built/installed with the 'gen_tar' target, rsync is
> used for the installation step to copy files. Extra care is needed for
> tests that have symlinks. Commit ae108c48b5d2 ("selftests: net: Fix
> cross-tree inclusion of scripts") added '-L' (transform symlink into
> referent file/dir) to rsync, to fix dangling links. However, that
> broke some tests where the symlink (being a symlink) is part of the
> test (e.g. exec:execveat).
>
> Use rsync's '--copy-unsafe-links' that does right thing.
>
> Fixes: ae108c48b5d2 ("selftests: net: Fix cross-tree inclusion of scripts")
> Signed-off-by: Björn Töpel <bjorn@rivosinc.com>
> ---
> tools/testing/selftests/lib.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Benjamin Poirier <bpoirier@nvidia.com>
Thank you for the fix.
prev parent reply other threads:[~2023-08-22 15:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 13:58 [PATCH] selftests: Keep symlinks, when possible Björn Töpel
2023-08-22 15:49 ` Benjamin Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOTZHhGLnQKOhITt@d3 \
--to=bpoirier@nvidia.com \
--cc=bjorn@kernel.org \
--cc=bjorn@rivosinc.com \
--cc=jtoppins@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox