From: Tejun Heo <tj@kernel.org>
To: Tio Zhang <tiozhang@didiglobal.com>
Cc: linux-kernel@vger.kernel.org, jiangshanlai@gmail.com,
zyhtheonly@gmail.com, zyhtheonly@yeah.net
Subject: Re: [PATCH v2] workqueue: let WORKER_CPU_INTENSIVE be included in watchdog
Date: Tue, 22 Aug 2023 09:49:49 -1000 [thread overview]
Message-ID: <ZOURXUD7EfO0JVFE@slm.duckdns.org> (raw)
In-Reply-To: <20230822110609.GA3702@didi-ThinkCentre-M930t-N000>
On Tue, Aug 22, 2023 at 07:06:51PM +0800, Tio Zhang wrote:
> When a pool has a worker with WORKER_CPU_INTENSIVE set but other workers
> are not that busy, the pool->worklist will mostly be empty, which leads
> the intensive work always having a chance of escaping from the watchdog's
> check. This may cause watchdog miss finding out a forever running work
> in WQ_CPU_INTENSIVE.
>
> Also, after commit '616db8779b1e3f93075df691432cccc5ef3c3ba0',
> workers with potentially intensive works will automatically be converted
> into WORKER_CPU_INTENSIVE. This might let watchdog to miss all work
> potentially running forever.
The watchdog is there to ensure forward progress. CPU_INTENSIVE work items
don't block other work items, so I'm not sure why it should trigger the
watchdog.
Thanks.
--
tejun
next prev parent reply other threads:[~2023-08-22 19:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 10:23 [PATCH] workqueue: let WORKER_CPU_INTENSIVE be included in watchdog Tio Zhang
2023-08-14 14:18 ` kernel test robot
2023-08-22 11:06 ` [PATCH v2] " Tio Zhang
2023-08-22 19:49 ` Tejun Heo [this message]
2023-08-24 8:36 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOURXUD7EfO0JVFE@slm.duckdns.org \
--to=tj@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiozhang@didiglobal.com \
--cc=zyhtheonly@gmail.com \
--cc=zyhtheonly@yeah.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox