From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Abdel Alkuor <alkuor@gmail.com>
Cc: devicetree@vger.kernel.org, gregkh@linuxfoundation.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, abdelalkuor@geotab.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v4 0/2] Add support for TPS25750
Date: Wed, 23 Aug 2023 10:02:51 +0300 [thread overview]
Message-ID: <ZOWvG1MQw37IOHcM@kuha.fi.intel.com> (raw)
In-Reply-To: <cover.1692559293.git.alkuor@gmail.com>
On Sun, Aug 20, 2023 at 03:32:25PM -0400, Abdel Alkuor wrote:
> TPS25750 is USB Type-C and PD controller. The device is
> highly configurable using App Customization online Tool
> developed by TI to generate loadable binary.
>
> TPS25750 supports three modes; PTCH, APP, and BOOT. A configuration
> can only be applied when the controller is on PTCH mode.
>
> The controller attempts to load a configuration from EEPROM on
> I2Cm bus. If no EEPROM is detected, then the driver tries to load
> a configuration on I2Cs bus using a firmware file defined
> in DT.
>
> The driver implements the binary loading sequence which
> can be found on pg.53 in TPS25750 Host Interface Technical
> Reference Manual (Rev. A) https://tinyurl.com/y9rkhu8a
>
> The driver only supports resume pm callback as power management is
> automatically controlled by the device. See pg.47 in TPS25750
> datasheet https://tinyurl.com/3vfd2k43
>
> v4:
> - PATCH 1: No change
> - PATCH 2: Fix comments style and drop of_match_ptr
> v3:
> - PATCH 1: Fix node name
> - PATCH 2: Upload tps25750 driver patch
> v2:
> - PATCH 1: General properties clean up
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Abdel Alkuor (2):
> dt-bindings: usb: Add ti,tps25750
> USB: typec: Add TI TPS25750 USB Type-C controller
>
> .../devicetree/bindings/usb/ti,tps25750.yaml | 81 ++
> drivers/usb/typec/Kconfig | 13 +
> drivers/usb/typec/Makefile | 1 +
> drivers/usb/typec/tps25750.c | 1077 +++++++++++++++++
> drivers/usb/typec/tps25750.h | 162 +++
> 5 files changed, 1334 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/ti,tps25750.yaml
> create mode 100644 drivers/usb/typec/tps25750.c
> create mode 100644 drivers/usb/typec/tps25750.h
TPS25750 has the same host interface as TI TPS65xxx controllers, no?
The register offsets at least are exactly the same.
You need to first try to incorporate support for TI25750 support into
the existing tipd driver (drivers/usb/typec/tipd/).
thanks,
--
heikki
next prev parent reply other threads:[~2023-08-23 7:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-20 19:32 [PATCH v4 0/2] Add support for TPS25750 Abdel Alkuor
2023-08-20 19:32 ` [PATCH v4 1/2] dt-bindings: usb: Add ti,tps25750 Abdel Alkuor
2023-08-20 19:32 ` [PATCH v4 2/2] USB: typec: Add TI TPS25750 USB Type-C controller Abdel Alkuor
2023-08-28 10:14 ` Uwe Kleine-König
2023-08-23 7:02 ` Heikki Krogerus [this message]
2023-08-29 1:05 ` [PATCH v4 0/2] Add support for TPS25750 Abdel Alkuor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOWvG1MQw37IOHcM@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=abdelalkuor@geotab.com \
--cc=alkuor@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox