From: Prashant Malani <pmalani@chromium.org>
To: "Patel, Utkarsh H" <utkarsh.h.patel@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"heikki.krogerus@linux.intel.com"
<heikki.krogerus@linux.intel.com>,
"bleung@chromium.org" <bleung@chromium.org>
Subject: Re: [PATCH v4 1/2] platform/chrome: cros_ec_typec: Configure Retimer cable type
Date: Wed, 23 Aug 2023 15:35:01 +0000 [thread overview]
Message-ID: <ZOYnJTqTajyyJV0d@chromium.org> (raw)
In-Reply-To: <MWHPR11MB0048018BB93C531401D00EF9A91FA@MWHPR11MB0048.namprd11.prod.outlook.com>
Hi Utkarsh,
On Aug 22 21:21, Patel, Utkarsh H wrote:
> Hi Prashant,
>
> > -----Original Message-----
> > From: Prashant Malani <pmalani@chromium.org>
> > Sent: Monday, August 21, 2023 4:31 PM
> > >
> > > We are only calling it once depending upon which mode we enter TBT Alt or
> > USB4.
> >
> > There should only be 1 "call site" and that should be sufficient to grab the VDO
> > from the framework for all circumstances. Whether the other invocation
> > doesn't get called under certain circumstances isn't as relevant.
>
> Are you suggesting something like this?
>
> static int cros_typec_configure_mux(struct cros_typec_data *typec, int port_num,)...
>
> if (port->mux_flags & USB_PD_MUX_USB4_ENABLED ||
> port->mux_flags & USB_PD_MUX_TBT_COMPAT_ENABLED)
> cable_tbt_vdo = cros_typec_get_cable_vdo(port, USB_TYPEC_TBT_SID);
My apologies, I misread the patch. I think this looks good.
Acked-by: Prashant Malani <pmalani@chromium.org>
next prev parent reply other threads:[~2023-08-23 15:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 2:47 [PATCH v4 0/2]Add support to configure active retimer cable Utkarsh Patel
2023-07-18 2:47 ` [PATCH v4 1/2] platform/chrome: cros_ec_typec: Configure Retimer cable type Utkarsh Patel
2023-07-31 3:52 ` Patel, Utkarsh H
2023-08-15 22:09 ` Patel, Utkarsh H
2023-08-18 17:01 ` Prashant Malani
2023-08-21 17:18 ` Patel, Utkarsh H
2023-08-21 23:30 ` Prashant Malani
2023-08-22 21:21 ` Patel, Utkarsh H
2023-08-23 15:35 ` Prashant Malani [this message]
2023-08-25 21:04 ` Patel, Utkarsh H
2023-08-26 7:40 ` Greg KH
2023-08-26 9:12 ` Greg KH
2023-07-18 2:47 ` [PATCH v4 2/2] usb: typec: intel_pmc_mux: Configure Active and Retimer Cable type Utkarsh Patel
2023-07-18 13:29 ` Greg KH
2023-07-19 20:46 ` Patel, Utkarsh H
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOYnJTqTajyyJV0d@chromium.org \
--to=pmalani@chromium.org \
--cc=bleung@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=utkarsh.h.patel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).