From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7390CC7EE2C for ; Fri, 25 Aug 2023 10:19:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238248AbjHYKSz (ORCPT ); Fri, 25 Aug 2023 06:18:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244164AbjHYKS3 (ORCPT ); Fri, 25 Aug 2023 06:18:29 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 492FC26AD; Fri, 25 Aug 2023 03:17:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692958673; x=1724494673; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=DXvtEtll5/zpeSBBt+eRjKo+MIEcDiI1EFE2uMAjDxI=; b=Xb32OIHG5KBJ2AvWFbTtk0lutLfnMrWISZU+QO98dMIvlab5AgJ25s6V DZ82rO5p0lwSkcxjyeqMspFrfE2g32tACdj44ZgDV8i3SefFxBbu26XDq 2OhnrrFjXB7BN4gUI4OSrJWYxo1IAxHF9rrFQnv/aPMWXjlef2YY2qH7P vFruIQtklhQMmS2LFApKyE2iFAk8CZnuICEx+7Tg3Ly6r++2PRnGHMe+7 O3EuL7bxR96uiRizstoC17hbmycYnEWu7FlsFxuAUJegnWIuZCQP9luwI A+pRkCQR9Vapi5Jd39WFRHcb4ctYD8JIscLn9f3x/deVrP8ukIoXszm1e Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10812"; a="359680475" X-IronPort-AV: E=Sophos;i="6.02,195,1688454000"; d="scan'208";a="359680475" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2023 03:17:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10812"; a="911243807" X-IronPort-AV: E=Sophos;i="6.02,195,1688454000"; d="scan'208";a="911243807" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP; 25 Aug 2023 03:17:41 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qZTsp-00Cekg-1R; Fri, 25 Aug 2023 13:17:39 +0300 Date: Fri, 25 Aug 2023 13:17:38 +0300 From: Andy Shevchenko To: Linhua Xu Cc: Linus Walleij , Orson Zhai , Baolin Wang , Chunyan Zhang , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, lh xu , Xiongpeng Wu Subject: Re: [PATCH 4/6] pinctrl: sprd: Add pinctrl support for UMS512 Message-ID: References: <20230825031826.31599-1-Linhua.xu@unisoc.com> <20230825031826.31599-5-Linhua.xu@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230825031826.31599-5-Linhua.xu@unisoc.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 25, 2023 at 11:18:24AM +0800, Linhua Xu wrote: > From: Linhua Xu > > This patch adds the pin control driver for UNISOC UMS512 platform. Read "Submitting Patches" documentation and find there what to do with "This patch..." ... > +config PINCTRL_SPRD_UMS512 > + tristate "Spreadtrum ums512 pinctrl driver" > + depends on OF Shouldn't you drop this from all drivers you have? I do not see this driver being dependent on the OF. > + depends on ARCH_SPRD || COMPILE_TEST > + select PINCTRL_SPRD ... kernel.h for ARRAY_SIZE() > +#include > +#include > +#include ... > +#define PINCTRL_REG_OFFSET 0x34 0x0034 > +#define PINCTRL_REG_MISC_OFFSET 0x434 > +static int sprd_pinctrl_probe(struct platform_device *pdev) > +{ > + return sprd_pinctrl_core_probe(pdev, sprd_ums512_pins_info, > + ARRAY_SIZE(sprd_ums512_pins_info), > + PINCTRL_REG_OFFSET, > + PINCTRL_REG_MISC_OFFSET); > +} ... > +static const struct of_device_id sprd_pinctrl_of_match[] = { > + { > + .compatible = "sprd,ums512-pinctrl", > + }, Can be one line. > + { }, Drop trailing comma in the terminator entry. > +}; ... > +static struct platform_driver sprd_pinctrl_driver = { > + .driver = { > + .name = "sprd-pinctrl", > + .of_match_table = sprd_pinctrl_of_match, > + }, > + .probe = sprd_pinctrl_probe, > + .remove = sprd_pinctrl_remove, > + .shutdown = sprd_pinctrl_shutdown, > +}; > + Redundant blank line. > +module_platform_driver(sprd_pinctrl_driver); -- With Best Regards, Andy Shevchenko