Re: [PATCH 3/6] pinctrl: sprd: Modify pull-up parameters

Andy Shevchenko
2023-08-25T10:14:07Z

On Fri, Aug 25, 2023 at 11:18:23AM +0800, Linhua Xu wrote:
> From: Linhua Xu <Linhua.Xu@unisoc.com>
>
> For UNISOC pin controller, there are three different configurations of
> pull-up drive current: 1 for pull-up resistor is 20K, 2 for pull-up
> resistor is 4.7K and 3 for pull-up resistor is 1.8K. Thus modify them.

...

> - if (arg == 20000)
> - else if (arg == 4700)

> + if (arg == 3)
> + else if (arg == 2)
> + else if (arg == 1)

This will break existing users. What's wrong with leaving this as is
and adding 1.8kOhm?

--
With Best Regards,
Andy Shevchenko