From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Lucas Segarra Fernandez <lucas.segarra.fernandez@intel.com>,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
qat-linux@intel.com, alx@kernel.org,
Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Subject: Re: [PATCH v2 2/2] crypto: qat - add pm_status debugfs file
Date: Fri, 25 Aug 2023 15:38:41 +0300 [thread overview]
Message-ID: <ZOig0RNTKs+P91V0@smile.fi.intel.com> (raw)
In-Reply-To: <ZOiE6GMY5Qb2S53A@gondor.apana.org.au>
On Fri, Aug 25, 2023 at 06:39:36PM +0800, Herbert Xu wrote:
> On Fri, Aug 18, 2023 at 12:23:09PM +0200, Lucas Segarra Fernandez wrote:
> > #include <linux/bitfield.h>
> > +#include <linux/bits.h>
>
> This is redundant if you include linux/kernel.
Why?!
Can we avoid using kernel.h, please?
> > +#include <linux/dma-mapping.h>
> > +#include <linux/fs.h>
> > #include <linux/iopoll.h>
> > #include <linux/kstrtox.h>
> > +#include <linux/slab.h>
> > +#include <linux/stddef.h>
>
> So is this.
Ditto.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-25 12:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 10:23 [PATCH v2 0/2] Add debugfs pm_status for qat driver Lucas Segarra Fernandez
2023-08-18 10:23 ` [PATCH v2 1/2] crypto: qat - refactor included headers Lucas Segarra Fernandez
2023-08-25 10:36 ` Herbert Xu
2023-08-25 10:41 ` Herbert Xu
2023-08-25 11:00 ` Herbert Xu
2023-08-25 12:37 ` Andy Shevchenko
2023-08-28 10:22 ` Herbert Xu
2023-08-28 10:46 ` Andy Shevchenko
2023-08-29 10:18 ` Herbert Xu
2023-08-29 14:08 ` Andy Shevchenko
2023-08-31 3:55 ` Herbert Xu
2023-08-31 11:18 ` Alejandro Colomar
2023-08-31 13:29 ` Andy Shevchenko
2023-08-31 13:26 ` Andy Shevchenko
2023-08-18 10:23 ` [PATCH v2 2/2] crypto: qat - add pm_status debugfs file Lucas Segarra Fernandez
2023-08-25 10:39 ` Herbert Xu
2023-08-25 12:38 ` Andy Shevchenko [this message]
2023-08-25 11:01 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOig0RNTKs+P91V0@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=alx@kernel.org \
--cc=giovanni.cabiddu@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.segarra.fernandez@intel.com \
--cc=qat-linux@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox