RE: [PATCH v2 2/2] selftests/net: replace ternary operator with min()/max()

David Laight
2023-08-25T09:33:14Z

From: Mahmoud Maatuq
> Sent: 24 August 2023 21:24
....
> tdeliver = glob_tstart + ts->delay_us * 1000;
> - tdeliver_max = tdeliver_max > tdeliver ?
> - tdeliver_max : tdeliver;
> + tdeliver_max = max(tdeliver_max, tdeliver);

That was spectacularly horrid...
What is wrong with using:
if (tdeliver > tdeliver_max)
tdeliver_max = tdeliver;
That is pretty obviously calculating the upper bound.
Even the version with max() needs extra parsing by the human reader.

(The only issue is whether it reads better with the if condition
reversed.)

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)