From: Jon Mason <jdmason@kudzu.us>
To: Max Hawking <maxahawking@sonnenkinder.org>
Cc: Dave Jiang <dave.jiang@intel.com>,
Allen Hubbe <allenbh@gmail.com>,
Serge Semin <fancer.lancer@gmail.com>,
Minjie Du <duminjie@vivo.com>,
ntb@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ntb_perf: Fix printk format
Date: Sun, 10 Sep 2023 11:04:30 -0400 [thread overview]
Message-ID: <ZP3a/oD0nzaFdPo/@kudzu.us> (raw)
In-Reply-To: <f2fb85b9-278d-9e12-b61c-d951c71bf2f6@gmx.net>
On Sun, Sep 10, 2023 at 12:34:34AM -0700, Max Hawking wrote:
> The correct printk format is %pa or %pap, but not %pa[p].
>
> Fixes: 99a06056124d ("NTB: ntb_perf: Fix address err in perf_copy_chunk")
> Signed-off-by: Max Hawking <maxahawking@sonnenkinder.org>
> ---
> drivers/ntb/test/ntb_perf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c
> index 553f1f46bc66..72bc1d017a46 100644
> --- a/drivers/ntb/test/ntb_perf.c
> +++ b/drivers/ntb/test/ntb_perf.c
> @@ -1227,7 +1227,7 @@ static ssize_t perf_dbgfs_read_info(struct file
> *filep, char __user *ubuf,
> "\tOut buffer addr 0x%pK\n", peer->outbuf);
>
> pos += scnprintf(buf + pos, buf_size - pos,
> - "\tOut buff phys addr %pa[p]\n", &peer->out_phys_addr);
> + "\tOut buff phys addr %pap\n", &peer->out_phys_addr);
>
> pos += scnprintf(buf + pos, buf_size - pos,
> "\tOut buffer size %pa\n", &peer->outbuf_size);
> --
> 2.41.0
For some reason this patch isn't applying cleanly for me, I'm seeing
the following issue:
$ b4 am -o - f2fb85b9-278d-9e12-b61c-d951c71bf2f6@gmx.net | patch -p1
...
patching file drivers/ntb/test/ntb_perf.c
patch: **** malformed patch at line 23: *filep, char __user *ubuf,
Please rebase and resend.
Thanks,
Jon
next prev parent reply other threads:[~2023-09-10 15:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-10 7:34 [PATCH] ntb_perf: Fix printk format Max Hawking
2023-09-10 15:04 ` Jon Mason [this message]
2023-09-10 19:18 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZP3a/oD0nzaFdPo/@kudzu.us \
--to=jdmason@kudzu.us \
--cc=allenbh@gmail.com \
--cc=dave.jiang@intel.com \
--cc=duminjie@vivo.com \
--cc=fancer.lancer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxahawking@sonnenkinder.org \
--cc=ntb@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox