From: Willy Tarreau <w@1wt.eu>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/nolibc: libc-test: avoid -Wstringop-overflow warnings
Date: Mon, 11 Sep 2023 08:04:49 +0200 [thread overview]
Message-ID: <ZP6uAT0jmseRHkzG@1wt.eu> (raw)
In-Reply-To: <20230910-nolibc-poll-fault-v1-1-2b7a16f48259@weissschuh.net>
Hi Thomas,
On Sun, Sep 10, 2023 at 09:29:01PM +0200, Thomas Weißschuh wrote:
> Newer versions of glibc annotate the poll() function with
> __attribute__(access) which triggers a compiler warning inside the
> testcase poll_fault.
> Avoid this by using a plain NULL which is enough for the testcase.
> To avoid potential future warnings also adapt the other EFAULT
> testcases, except select_fault as NULL is a valid value for its
> argument.
(...)
Looks good to me. I wouldn't be surprised if we're soon forced to do
the same with select() on some archs where it might be emulated.
Feel free to push it to the shared repo.
Thanks!
Willy
next prev parent reply other threads:[~2023-09-11 6:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-10 19:29 [PATCH] selftests/nolibc: libc-test: avoid -Wstringop-overflow warnings Thomas Weißschuh
2023-09-11 6:04 ` Willy Tarreau [this message]
2023-09-11 14:26 ` Thomas Weißschuh
2023-09-11 14:30 ` Willy Tarreau
2023-09-11 14:47 ` Thomas Weißschuh
2023-09-11 15:02 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZP6uAT0jmseRHkzG@1wt.eu \
--to=w@1wt.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox