From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E720DEE57DF for ; Mon, 11 Sep 2023 06:06:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232388AbjIKGGP (ORCPT ); Mon, 11 Sep 2023 02:06:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231755AbjIKGGN (ORCPT ); Mon, 11 Sep 2023 02:06:13 -0400 Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 75199CEF; Sun, 10 Sep 2023 23:05:30 -0700 (PDT) Received: (from willy@localhost) by mail.home.local (8.17.1/8.17.1/Submit) id 38B64njx013318; Mon, 11 Sep 2023 08:04:49 +0200 Date: Mon, 11 Sep 2023 08:04:49 +0200 From: Willy Tarreau To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/nolibc: libc-test: avoid -Wstringop-overflow warnings Message-ID: References: <20230910-nolibc-poll-fault-v1-1-2b7a16f48259@weissschuh.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230910-nolibc-poll-fault-v1-1-2b7a16f48259@weissschuh.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Thomas, On Sun, Sep 10, 2023 at 09:29:01PM +0200, Thomas Weißschuh wrote: > Newer versions of glibc annotate the poll() function with > __attribute__(access) which triggers a compiler warning inside the > testcase poll_fault. > Avoid this by using a plain NULL which is enough for the testcase. > To avoid potential future warnings also adapt the other EFAULT > testcases, except select_fault as NULL is a valid value for its > argument. (...) Looks good to me. I wouldn't be surprised if we're soon forced to do the same with select() on some archs where it might be emulated. Feel free to push it to the shared repo. Thanks! Willy