From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68158CA0ED3 for ; Mon, 11 Sep 2023 22:08:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356386AbjIKWDl (ORCPT ); Mon, 11 Sep 2023 18:03:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236287AbjIKKKq (ORCPT ); Mon, 11 Sep 2023 06:10:46 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABF6E101; Mon, 11 Sep 2023 03:10:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694427041; x=1725963041; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=FZOFUYe1WhhZO3v6oURDqElM6ZV1goFETHTw7RTM4a0=; b=Ax8xivzdMSOwEwKgdlyYNh1yzPBH+7aYNOBtTHoZ3GBvHm2n7eD/jLYc ofxzg9DjrCYJGQ8Me6yMDQWW6Hx/MtQd/bzFyT2zKFHelO4+yDiJyt5CI 5hNJ3QpbPXyp6EWqbCwrINyO9oAXj1DxmM1/JGjy+rRAgLdVKFTIfvf3U beXtSeU7aTURF5wen1Uvyjo6qNSkrMnt0iLYQFvM8h1+zNypletoH5N+0 MqUk4UFTxlvRGIwrXdiyYzfZjb9jlt8OciuI1vUfuww8Q1TVZqtU5Vuzf fdwm9auKe9iyErXVll2si2Bnu9Nvduv02yiKAKzZRkv4ZoxHPeiFhX35+ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10829"; a="380743389" X-IronPort-AV: E=Sophos;i="6.02,243,1688454000"; d="scan'208";a="380743389" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2023 03:10:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10829"; a="990045128" X-IronPort-AV: E=Sophos;i="6.02,243,1688454000"; d="scan'208";a="990045128" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga006.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2023 03:10:39 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qfdsK-008HrE-2u; Mon, 11 Sep 2023 13:10:36 +0300 Date: Mon, 11 Sep 2023 13:10:36 +0300 From: Andy Shevchenko To: Biju Das Cc: Linus Walleij , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Biju Das Subject: Re: [PATCH v2 0/4] Match data improvements for mcp23s08 driver Message-ID: References: <20230909121903.34062-1-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230909121903.34062-1-biju.das.jz@bp.renesas.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 09, 2023 at 01:18:59PM +0100, Biju Das wrote: > This patch series aims to add match data improvements for mcp23s08 driver. > This patch series is only compile tested. Now, do you see the common grounds for unifying two data structure types you created? IN the common header you may introduce a type and use it in the both files. For the patches 1 & 3 (the API simplification): Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko