Re: [PATCH 1/2] power: supply: bq24257_charger: Make chip type and name in sync

Sebastian Reichel
2023-09-12T21:49:32Z

[-- Attachment #1: Type: text/plain, Size: 1072 bytes --]

Hi,

On Mon, Sep 11, 2023 at 01:15:09PM +0300, Andy Shevchenko wrote:
> On Sun, Sep 10, 2023 at 07:10:06AM +0000, Biju Das wrote:
> > Hi Andy Shevchenko,
> > > On Sat, Sep 02, 2023 at 08:33:30PM +0100, Biju Das wrote:
>
> ...
>
> > > > - if (ACPI_HANDLE(dev)) {
> > > > - acpi_id = acpi_match_device(dev->driver->acpi_match_table,
> > > > - &client->dev);
> > > > - if (!acpi_id) {
> > > > - dev_err(dev, "Failed to match ACPI device\n");
> > > > - return -ENODEV;
> > > > - }
> > > > - bq->chip = (enum bq2425x_chip)acpi_id->driver_data;
> > > > - } else {
> > > > - bq->chip = (enum bq2425x_chip)id->driver_data;
> > > > - }
> > >
> > > Do we still need acpi.h after this change?
> >
> > Yes, it is still needed as it is using
> > ACPI_PTR.
>
> Can we, please, drop ACPI_PTR() as it's more harmful than useful (same way as
> you dropped the ifdeffery for OF cases in other patches)?

I will go ahead and merge this series, ACPI_PTR() and
of_match_ptr() should be removed in a separate cleanup patch.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]