From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>, Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 4/4] drm/bridge: panel: Drop CONFIG_OF conditional around *_of_get_bridge()
Date: Thu, 31 Aug 2023 19:16:35 +0300 [thread overview]
Message-ID: <ZPC84+k8aot5LyGT@smile.fi.intel.com> (raw)
In-Reply-To: <OS0PR01MB592262D3EDAF424252157D5B86E5A@OS0PR01MB5922.jpnprd01.prod.outlook.com>
On Thu, Aug 31, 2023 at 10:47:24AM +0000, Biju Das wrote:
> > On Thu, Aug 31, 2023 at 09:09:38AM +0100, Biju Das wrote:
...
> > > Drop unnecessary CONFIG_OF conditional around devm_drm_of_get_bridge()
> > > and
> > > drmm_of_get_bridge() as it is guarded with #if..#else blocks in
> > > drm_bridge.h.
> >
> > This will increase the kernel size on non-OF system, to add functions that
> > are not used. I don't think the #ifdef here is problematic.
>
> OK agreed. I guess for NON-OF system it will give build error
> for function redefinition, if that is the case I would like to
> drop this patch.
>
> static inline struct drm_bridge *devm_drm_of_get_bridge()
>
> vs
>
> struct drm_bridge *devm_drm_of_get_bridge()
Yeah, yet another argument in favour of switching to fwnode.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-31 16:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 8:09 [PATCH v6 0/4] Drop ID table and conditionals around of_node pointers Biju Das
2023-08-31 8:09 ` [PATCH v6 1/4] drm/bridge/analogix/anx78xx: Drop ID table Biju Das
2023-09-06 15:41 ` Doug Anderson
2023-08-31 8:09 ` [PATCH v6 2/4] drm/bridge: Drop conditionals around of_node pointers Biju Das
2023-09-06 15:42 ` Doug Anderson
2023-08-31 8:09 ` [PATCH v6 3/4] drm/bridge: Drop CONFIG_OF " Biju Das
2023-08-31 9:29 ` Laurent Pinchart
2023-08-31 16:14 ` Andy Shevchenko
2023-09-06 15:42 ` Doug Anderson
2023-08-31 8:09 ` [PATCH v6 4/4] drm/bridge: panel: Drop CONFIG_OF conditional around *_of_get_bridge() Biju Das
2023-08-31 9:31 ` Laurent Pinchart
2023-08-31 10:47 ` Biju Das
2023-08-31 16:16 ` Andy Shevchenko [this message]
2023-09-06 15:42 ` Doug Anderson
2023-09-06 18:15 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPC84+k8aot5LyGT@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox