From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: "Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ASoC: ak4642: Simplify probe()
Date: Thu, 31 Aug 2023 16:37:08 +0300 [thread overview]
Message-ID: <ZPCXhDHMVAYHqhFC@smile.fi.intel.com> (raw)
In-Reply-To: <OS0PR01MB5922A08379222B0DF6D0323286E7A@OS0PR01MB5922.jpnprd01.prod.outlook.com>
On Tue, Aug 29, 2023 at 06:02:51PM +0000, Biju Das wrote:
> > On Mon, Aug 28, 2023 at 07:00:03PM +0100, Biju Das wrote:
...
> > > - if (np) {
> > > - const struct of_device_id *of_id;
> > > -
> >
> > > + if (dev_fwnode(dev)) {
> >
> > Why do we need this at all?
> It is replacement for np.
I am questioning it's necessity to begin with (even before your patch).
> > > mcko = ak4642_of_parse_mcko(dev);
> > > if (IS_ERR(mcko))
> > > mcko = NULL;
> >
> > This can suffice on its own, right?
> >
> > Can be done in a separate change as a precursor to this one.
>
> Agreed.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-31 14:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 18:00 [PATCH v2] ASoC: ak4642: Simplify probe() Biju Das
2023-08-29 15:24 ` Andy Shevchenko
2023-08-29 18:02 ` Biju Das
2023-08-31 13:37 ` Andy Shevchenko [this message]
2023-08-31 14:13 ` Biju Das
2023-09-11 23:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPCXhDHMVAYHqhFC@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox