From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D441EC83F37 for ; Thu, 31 Aug 2023 18:33:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347061AbjHaSde (ORCPT ); Thu, 31 Aug 2023 14:33:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233343AbjHaSdc (ORCPT ); Thu, 31 Aug 2023 14:33:32 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D1B7E65; Thu, 31 Aug 2023 11:33:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693506805; x=1725042805; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=px3FvT2RH7DAb7h5X2rn9hNLxQJQvAASvN2jtIrqh9o=; b=AASgif7GedMH45eJW5YI5lYhSf+bVlvKGTOR1avgmDoWx6eQbu40itm8 +PsirLsTy1GjYGcvDyMveHMOGhp1e5x1fab0ZQ0BioKFBG0Y3zH3RFzT5 toYEIWW8IG0gYV0SHrx/n7/okGAe04UrH2djXDF1/k3JXZh6SgW6cfeyU uVnH0EvIGYxILj8nNzFME2e/7wqDi8Xrh4EOUYtiCHhiy9UwMRLPGzoLs vXP7HSin5KprmsW8+Z1KVZRR6xRS9evG3vyafCEF8ohSwrfsOGpfDfkin 5SojNl/Jt0Dq1WMuEgjycO5H+qJ4VlXRCwf4yzGohlc0iIC/CJBv8gW/T w==; X-IronPort-AV: E=McAfee;i="6600,9927,10819"; a="375969039" X-IronPort-AV: E=Sophos;i="6.02,217,1688454000"; d="scan'208";a="375969039" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2023 11:33:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10819"; a="863234151" X-IronPort-AV: E=Sophos;i="6.02,217,1688454000"; d="scan'208";a="863234151" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2023 11:33:17 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qbmTh-005Tcq-0j; Thu, 31 Aug 2023 21:33:13 +0300 Date: Thu, 31 Aug 2023 21:33:12 +0300 From: Andy Shevchenko To: Ilpo =?iso-8859-1?Q?J=E4rvinen?= Cc: "Jiri Slaby (SUSE)" , Greg Kroah-Hartman , linux-serial , LKML , William Hubbs , Chris Brannon , Kirk Reiser , Samuel Thibault , Dmitry Torokhov , Arnd Bergmann , Max Staudt , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Dario Binacchi , Andreas Koensgen , Jeremy Kerr , Matt Johnston , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Peter Ujfalusi Subject: Re: [PATCH 16/36] tty: use u8 for chars Message-ID: References: <20230810091510.13006-1-jirislaby@kernel.org> <20230810091510.13006-17-jirislaby@kernel.org> <27366cad-30b2-e326-8d8f-c6fe17cf4899@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <27366cad-30b2-e326-8d8f-c6fe17cf4899@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 11, 2023 at 01:28:56PM +0300, Ilpo Järvinen wrote: > On Thu, 10 Aug 2023, Jiri Slaby (SUSE) wrote: ... > > @@ -22,9 +22,9 @@ struct tty_buffer { > > unsigned long data[]; > > }; > > > > -static inline unsigned char *char_buf_ptr(struct tty_buffer *b, int ofs) > > +static inline u8 *char_buf_ptr(struct tty_buffer *b, int ofs) > > { > > - return ((unsigned char *)b->data) + ofs; > > + return ((u8 *)b->data) + ofs; > > } > > Any particular reason why b->data is left unsigned long? It might be the performance issue due to unaligned accesses on some architectures. But I'm just speculating... -- With Best Regards, Andy Shevchenko