From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39F8CCA0FE6 for ; Fri, 1 Sep 2023 12:15:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347712AbjIAMPS (ORCPT ); Fri, 1 Sep 2023 08:15:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230006AbjIAMPR (ORCPT ); Fri, 1 Sep 2023 08:15:17 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80DC7E40; Fri, 1 Sep 2023 05:15:14 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10819"; a="376138995" X-IronPort-AV: E=Sophos;i="6.02,219,1688454000"; d="scan'208";a="376138995" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2023 05:15:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10819"; a="883170555" X-IronPort-AV: E=Sophos;i="6.02,219,1688454000"; d="scan'208";a="883170555" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga001.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2023 05:15:15 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qc33N-005fRS-1A; Fri, 01 Sep 2023 15:15:09 +0300 Date: Fri, 1 Sep 2023 15:15:09 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Linus Walleij , Support Opensource , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH 0/3] pinctrl: da9062: don't pull in internal GPIOLIB headers Message-ID: References: <20230901112926.13216-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230901112926.13216-1-brgl@bgdev.pl> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 01, 2023 at 01:29:23PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > I'm removing instances of users of internal GPIOLIB headers which should > not be included by anyone but GPIO core code. The pinctrl-da9062 driver > uses gpiochip_get_desc() which we should put into the gpio/driver.h > header as it does sometimes make sense for GPIO providers to get its own > descriptors without having to go through gpiochip_request_own_desc(). Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko