From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B64E9C83F2C for ; Sun, 3 Sep 2023 08:17:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235284AbjICIRm (ORCPT ); Sun, 3 Sep 2023 04:17:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233751AbjICIRm (ORCPT ); Sun, 3 Sep 2023 04:17:42 -0400 Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9163A189 for ; Sun, 3 Sep 2023 01:17:35 -0700 (PDT) Received: (from willy@localhost) by mail.home.local (8.17.1/8.17.1/Submit) id 3838H9TT027927; Sun, 3 Sep 2023 10:17:09 +0200 Date: Sun, 3 Sep 2023 10:17:09 +0200 From: Willy Tarreau To: Ammar Faizi Cc: Alviro Iskandar Setiawan , Thomas =?iso-8859-1?Q?Wei=DFschuh?= , David Laight , Nicholas Rosenberg , Michael William Jonathan , GNU/Weeb Mailing List , Linux Kernel Mailing List Subject: Re: [RFC PATCH v3 2/4] tools/nolibc: x86-64: Use `rep stosb` for `memset()` Message-ID: References: <20230902133505.2176434-1-ammarfaizi2@gnuweeb.org> <20230902133505.2176434-3-ammarfaizi2@gnuweeb.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 03, 2023 at 02:34:22AM +0700, Ammar Faizi wrote: > On Sun, Sep 03, 2023 at 02:28:18AM +0700, Alviro Iskandar Setiawan wrote: > > nit: Be consistent. Use \n\t for the memset too. > > Good catch, I'll fix that in v4 revision. Ammar, I'm overall fine with your series. I can as well add the missing \t to your patch while merging it, or wait for your v4, just let me know. Thanks, Willy