From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10681C83F33 for ; Mon, 4 Sep 2023 06:32:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233267AbjIDGc5 (ORCPT ); Mon, 4 Sep 2023 02:32:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231654AbjIDGc4 (ORCPT ); Mon, 4 Sep 2023 02:32:56 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2AC9D9 for ; Sun, 3 Sep 2023 23:32:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693809173; x=1725345173; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ql1SeTsT6ragrHVV+S7gG0Gx1pDdAI3ifiqhz6TY8BI=; b=ZJDw/NoBZHdGNyKNRvgepmrApPgaqWdzZRFR0a/DqeRRnqFbAx9Iw5oh x/RvEyfCb2YN1ISG+GmKo0mcG+uiNH2sZEIKoCknGY3qXKPzkMtxhOjVx oWM8eJYBZeZpAxQibNhkC54b30VN4urFse+NYaITPAeww2N/YCCYFlcuE cGDLjdOLflMPsfI8YABF7HPbeXu6WhHujyu4nH1Yecx1qy4UjF1mARFHX 3KKevdw+W04AsF+Eu3FOj12E4GeZE6mDrtPF2za/9m9JJmvTixvew3dmG kByRltZCKeAaYLSnGeWKKJk/fU2SRP+JQKyuiFgBXmg7ZEHWfRuo6IYQQ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10822"; a="366750378" X-IronPort-AV: E=Sophos;i="6.02,225,1688454000"; d="scan'208";a="366750378" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2023 23:32:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10822"; a="914404453" X-IronPort-AV: E=Sophos;i="6.02,225,1688454000"; d="scan'208";a="914404453" Received: from acohen8-mobl2.ger.corp.intel.com (HELO intel.com) ([10.252.59.133]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2023 23:32:44 -0700 Date: Mon, 4 Sep 2023 08:32:40 +0200 From: Andi Shyti To: Jim Cromie Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, daniel.vetter@ffwll.ch, daniel@ffwll.ch, jani.nikula@intel.com, ville.syrjala@linux.intel.com, seanpaul@chromium.org, robdclark@gmail.com, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Imre Deak , Radhakrishna Sripada , Mika Kahola , =?iso-8859-15?Q?Jos=E9?= Roberto de Souza , Ankit Nautiyal , Andrzej Hajda , Matthew Auld , Andi Shyti , "Jason A. Donenfeld" , Rob Clark , Chris Wilson , Fei Yang Subject: Re: [PATCH v2 3/6] drm_dbg: add trailing newlines to msgs Message-ID: References: <20230903184607.272198-1-jim.cromie@gmail.com> <20230903184607.272198-4-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230903184607.272198-4-jim.cromie@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jim, On Sun, Sep 03, 2023 at 12:46:00PM -0600, Jim Cromie wrote: > By at least strong convention, a print-buffer's trailing newline says > "message complete, send it". The exception (no TNL, followed by a call > to pr_cont) proves the general rule. > > Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, > 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks. > > No functional changes. > > Signed-off-by: Jim Cromie Reviewed-by: Andi Shyti Andi