From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Utkarsh Patel <utkarsh.h.patel@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
pmalani@chromium.org, chrome-platform@lists.linux.dev,
andriy.shevchenko@linux.intel.com, bleung@chromium.org
Subject: Re: [PATCH v2 3/5] usb: pd: Add helper macro to get Type C cable speed
Date: Mon, 4 Sep 2023 10:08:38 +0300 [thread overview]
Message-ID: <ZPWCdiSkeRA+CJ+i@kuha.fi.intel.com> (raw)
In-Reply-To: <20230830223950.1360865-4-utkarsh.h.patel@intel.com>
On Wed, Aug 30, 2023 at 03:39:48PM -0700, Utkarsh Patel wrote:
> Added a helper macro to get the Type C cable speed when provided the
> cable VDO.
>
> Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> Changes in v2:
> - This change is being added as new patch in this series.
>
> include/linux/usb/pd_vdo.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/usb/pd_vdo.h b/include/linux/usb/pd_vdo.h
> index b057250704e8..3a747938cdab 100644
> --- a/include/linux/usb/pd_vdo.h
> +++ b/include/linux/usb/pd_vdo.h
> @@ -376,6 +376,7 @@
> | ((vbm) & 0x3) << 9 | (sbu) << 8 | (sbut) << 7 | ((cur) & 0x3) << 5 \
> | (vbt) << 4 | (sopp) << 3 | ((spd) & 0x7))
>
> +#define VDO_TYPEC_CABLE_SPEED(vdo) ((vdo) & 0x7)
> #define VDO_TYPEC_CABLE_TYPE(vdo) (((vdo) >> 18) & 0x3)
>
> /*
> --
> 2.25.1
--
heikki
next prev parent reply other threads:[~2023-09-04 7:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 22:39 [PATCH v2 0/5] Displayport Alternate Mode 2.1 Support Utkarsh Patel
2023-08-30 22:39 ` [PATCH v2 1/5] usb: typec: Add " Utkarsh Patel
2023-08-30 22:39 ` [PATCH v2 2/5] usb: typec: Add Active or Passive cable defination to cable discover mode VDO Utkarsh Patel
2023-09-04 7:07 ` Heikki Krogerus
2023-08-30 22:39 ` [PATCH v2 3/5] usb: pd: Add helper macro to get Type C cable speed Utkarsh Patel
2023-09-04 7:08 ` Heikki Krogerus [this message]
2023-09-04 7:11 ` Heikki Krogerus
2023-09-05 23:47 ` Patel, Utkarsh H
2023-08-30 22:39 ` [PATCH v2 4/5] platform/chrome: cros_ec_typec: Add Displayport Alternatemode 2.1 Support Utkarsh Patel
2023-08-31 15:24 ` Patel, Utkarsh H
2023-09-08 17:03 ` Prashant Malani
2023-09-08 20:11 ` Patel, Utkarsh H
2023-08-30 22:39 ` [PATCH v2 5/5] usb: typec: intel_pmc_mux: Configure Displayport Alternate mode 2.1 Utkarsh Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPWCdiSkeRA+CJ+i@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pmalani@chromium.org \
--cc=utkarsh.h.patel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox