From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF139C83F3F for ; Mon, 4 Sep 2023 07:56:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348675AbjIDH4q (ORCPT ); Mon, 4 Sep 2023 03:56:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350587AbjIDH4n (ORCPT ); Mon, 4 Sep 2023 03:56:43 -0400 Received: from pandora.armlinux.org.uk (unknown [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68C6E1AA for ; Mon, 4 Sep 2023 00:56:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=yKzvCJmnQvqvc/k76bWFjHOAKJTfe53S8mkQv0zVv1o=; b=afDpWD6AoRKTCd197BrfH6sycp Y6BH2TAX4pWXa4+MlUX7EinBMJgz9cdRAeKL9MGFgMXPJiES2l3rrTWKKxbNnkVyshRxnCh7yZIlm VUim3frX788SZt+IhJGmVTLka5AN3kmLAdMCeJOlU7A88GY/fDNWa3xf/gazWbLeS/JsdHICibl6p gX4SIkO6Umxg4c0rwwJrzirY0+7zaNLh/1iWYL/ClKOZAp34x09DKEbUs2LejUwI8Z8/9QlYuP8Ib gPl9KJ2CK+pK5saqdv9sKLhVatWVdvIhAmeqV00GyVSH33MvmNSKiAC4uNKJQDkUKFCfzu/rC+46T PLombHtA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:45746) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qd4Rg-0006Zp-0f; Mon, 04 Sep 2023 08:56:28 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qd4Rg-0002LQ-NI; Mon, 04 Sep 2023 08:56:28 +0100 Date: Mon, 4 Sep 2023 08:56:28 +0100 From: "Russell King (Oracle)" To: Douglas Anderson Cc: dri-devel@lists.freedesktop.org, Maxime Ripard , airlied@gmail.com, daniel@ffwll.ch, linux-kernel@vger.kernel.org Subject: Re: [RFT PATCH 01/15] drm/armada: Call drm_atomic_helper_shutdown() at shutdown time Message-ID: References: <20230901234202.566951-1-dianders@chromium.org> <20230901164111.RFT.1.I3d5598bd73a59b5ded71430736c93f67dc5dea61@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230901164111.RFT.1.I3d5598bd73a59b5ded71430736c93f67dc5dea61@changeid> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 01, 2023 at 04:41:12PM -0700, Douglas Anderson wrote: > Based on grepping through the source code this driver appears to be > missing a call to drm_atomic_helper_shutdown() at system shutdown > time. Among other things, this means that if a panel is in use that it > won't be cleanly powered off at system shutdown time. > > The fact that we should call drm_atomic_helper_shutdown() in the case > of OS shutdown/restart comes straight out of the kernel doc "driver > instance overview" in drm_drv.c. > > This driver was fairly easy to update. The drm_device is stored in the > drvdata so we just have to make sure the drvdata is NULL whenever the > device is not bound. To make things simpler, > drm_atomic_helper_shutdown() has been modified to consider a NULL > drm_device as a noop in the patch ("drm/atomic-helper: > drm_atomic_helper_shutdown(NULL) should be a noop"). > > Suggested-by: Maxime Ripard > Signed-off-by: Douglas Anderson As the listed driver author for the reasons I've stated - NAK. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!