From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE028C83F3F for ; Mon, 4 Sep 2023 09:30:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239752AbjIDJac (ORCPT ); Mon, 4 Sep 2023 05:30:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229731AbjIDJab (ORCPT ); Mon, 4 Sep 2023 05:30:31 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28D81BF; Mon, 4 Sep 2023 02:30:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693819828; x=1725355828; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=MW9q+YZhg4vjahZ7s+Ly/jSrnaKMwzwsb0Yy4HuYxYQ=; b=O2iYspfAw5b/ajPCLQ3cBxH7tqe1uXzf2LpPJwOVIBhpJnYgkZW6Q0kM ghvbsNGljqoqpCu3MUouDuLiwd/2t3zUxq+i8dmkRcBMtxLsjQRHaereo JEzCxXAAWRyV15XFcNAZqfeYWur+V7pNh9TGOyBh0o9kbL/ZjN7vKevVh ML0RriWsi4oK4GUv/29Tm+EVJv6DngRR1x0I/lGIU1hkUellFCJirl1+C vC/pCBdUAke4/E1k8Z963Ht52MvOsFiTHqJXHNxDfLLC3rzaVykjKjpvZ VR7kyUNivuvmjgm3W75Z2Bk02gFWzH3K7XrRgFYEcJJb8uUlmgTro7VB9 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10822"; a="462926132" X-IronPort-AV: E=Sophos;i="6.02,226,1688454000"; d="scan'208";a="462926132" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2023 02:30:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10822"; a="717480614" X-IronPort-AV: E=Sophos;i="6.02,226,1688454000"; d="scan'208";a="717480614" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga006.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2023 02:30:26 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qd5uZ-006O0X-1j; Mon, 04 Sep 2023 12:30:23 +0300 Date: Mon, 4 Sep 2023 12:30:23 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Linus Walleij , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH 1/2] gpiolib: rename gpio_set_debounce_timeout() for consistency Message-ID: References: <20230904073410.5880-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 04, 2023 at 12:24:53PM +0300, Andy Shevchenko wrote: > On Mon, Sep 04, 2023 at 09:34:09AM +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > All other functions that manipulate a struct gpio_desc use the gpiod_ > > prefix. Follow this convention and rename gpio_set_debounce_timeout() to > > gpiod_set_debounce_timeout(). > > No, that's not true. This one is inline with the other gpio_set() _internal_ > APIs. If renamed, should be done consistently. It's even broader, like for_each_gpio_desc(). So, looking at that one I would rather use gpio_desc_ prefix / suffix than gpiod in case you are so eager to rename (Personally I consider this as unneeded churn). Also consider going thru all _internal_ APIs, like gpiod_not_found(), to be renamed to gpio_desc_not_found(). -- With Best Regards, Andy Shevchenko