From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Shenghao Ding <shenghao-ding@ti.com>
Cc: tiwai@suse.de, robh+dt@kernel.org, lgirdwood@gmail.com,
perex@perex.cz, pierre-louis.bossart@linux.intel.com,
kevin-lu@ti.com, 13916275206@139.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
liam.r.girdwood@intel.com, mengdong.lin@intel.com,
baojun.xu@ti.com, thomas.gfeller@q-drop.com, peeyush@ti.com,
navada@ti.com, broonie@kernel.org, gentuser@gmail.com
Subject: Re: [PATCH v1 1/2] ALSA: hda/tas2781: Update tas2781 HDA driver
Date: Mon, 4 Sep 2023 13:17:23 +0300 [thread overview]
Message-ID: <ZPWus9/OCJ/DJHQq@smile.fi.intel.com> (raw)
In-Reply-To: <20230903143759.92-1-shenghao-ding@ti.com>
On Sun, Sep 03, 2023 at 10:37:57PM +0800, Shenghao Ding wrote:
> Support ACPI_ID both TXNW2781 and TIAS2781, and revert structure
> cs35l41_dev_name.
...
> + /* exactly match either TXNW2781 or TIAS2781 */
> + /* the rest must be exact matching */
> + snprintf(tmp, sizeof(tmp), "-%s:00", "TXNW2781");
> +
> + if (!strcmp(d + n, tmp))
> + return 1;
> +
> /* the rest must be exact matching */
> - snprintf(tmp, sizeof(tmp), "-%s:00", p->hid);
> + snprintf(tmp, sizeof(tmp), "-%s:00", "TIAS2781");
Basically this should use acpi_dev_match infra like Intel drivers do.
But I haven't read code deeply to understand if it's the case here or
not.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-09-04 10:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-03 14:37 [PATCH v1 1/2] ALSA: hda/tas2781: Update tas2781 HDA driver Shenghao Ding
2023-09-03 14:37 ` [PATCH v1 2/2] " Shenghao Ding
2023-09-03 16:33 ` Takashi Iwai
2023-09-03 16:44 ` Takashi Iwai
2023-09-03 16:32 ` [PATCH v1 1/2] " Takashi Iwai
2023-09-04 10:17 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPWus9/OCJ/DJHQq@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=13916275206@139.com \
--cc=alsa-devel@alsa-project.org \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=gentuser@gmail.com \
--cc=kevin-lu@ti.com \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mengdong.lin@intel.com \
--cc=navada@ti.com \
--cc=peeyush@ti.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=shenghao-ding@ti.com \
--cc=thomas.gfeller@q-drop.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox