From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4A05C83F2C for ; Mon, 4 Sep 2023 10:32:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240073AbjIDKc0 (ORCPT ); Mon, 4 Sep 2023 06:32:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230121AbjIDKcZ (ORCPT ); Mon, 4 Sep 2023 06:32:25 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4374AE6 for ; Mon, 4 Sep 2023 03:32:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693823542; x=1725359542; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=zu+tMGAxaM9YFrYI5l7kCZRRlpRcpVet28df0zWTJwc=; b=dlqvgRzaoUVSA/UIPv47n9pQK6T4lyaL8LPhifoXkVXY7GI2jNL3MA+Z WcutBnTEaPFuPTRX/xYkj5CgHc1DBKjew7BVTGoKq/qRnAII97AEaTvEL 7E5mi/MN+P7ThzQMTHKFSdXcOaOG4313gDrneTkKGC6iWkXs482vchzdC EgT+ftid1ulqWEgpk3ZpcZV8rv0Te9LvG3GclnbBrc6AaLCxGS0i8sJKn A5d8gwSaTXPHZzwSMUyMdOir9eZweFJftvLs+zIbII2CYMNJBt7m+cKCn LqhpLRQZj4Eryvi0rXrL9EKBvi6QU5clVL1cGsHK3iKXuumMttyeMPsfQ A==; X-IronPort-AV: E=McAfee;i="6600,9927,10822"; a="375461215" X-IronPort-AV: E=Sophos;i="6.02,226,1688454000"; d="scan'208";a="375461215" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2023 03:32:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10822"; a="806220201" X-IronPort-AV: E=Sophos;i="6.02,226,1688454000"; d="scan'208";a="806220201" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2023 03:32:17 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qd6sQ-006Osv-0k; Mon, 04 Sep 2023 13:32:14 +0300 Date: Mon, 4 Sep 2023 13:32:13 +0300 From: Andy Shevchenko To: Shenghao Ding Cc: tiwai@suse.de, robh+dt@kernel.org, lgirdwood@gmail.com, perex@perex.cz, pierre-louis.bossart@linux.intel.com, kevin-lu@ti.com, 13916275206@139.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, liam.r.girdwood@intel.com, mengdong.lin@intel.com, baojun.xu@ti.com, thomas.gfeller@q-drop.com, peeyush@ti.com, navada@ti.com, broonie@kernel.org, gentuser@gmail.com Subject: Re: [PATCH v1] ALSA: hda/tas2781: Update tas2781 HDA driver Message-ID: References: <20230904090725.1388-1-shenghao-ding@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230904090725.1388-1-shenghao-ding@ti.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 04, 2023 at 05:07:24PM +0800, Shenghao Ding wrote: > Revert structure cs35l41_dev_name and redefine tas2781_generic_fixup. ... > /* check the bus name */ > - if (strncmp(d, p->bus, n)) > + if (strncmp(d, bus, n)) > return 0; > /* skip the bus number */ > if (isdigit(d[n])) > n++; > /* the rest must be exact matching */ > - snprintf(tmp, sizeof(tmp), "-%s:00", p->hid); > + snprintf(tmp, sizeof(tmp), "-%s:00", "TIAS2781"); > > return !strcmp(d + n, tmp); Try to use one of the respectve acpi_*_match*() APIs. -- With Best Regards, Andy Shevchenko