From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B772C83F2C for ; Mon, 4 Sep 2023 17:52:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353361AbjIDRws (ORCPT ); Mon, 4 Sep 2023 13:52:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234515AbjIDRwr (ORCPT ); Mon, 4 Sep 2023 13:52:47 -0400 Received: from mail-ot1-x32b.google.com (mail-ot1-x32b.google.com [IPv6:2607:f8b0:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AF3FCA for ; Mon, 4 Sep 2023 10:52:43 -0700 (PDT) Received: by mail-ot1-x32b.google.com with SMTP id 46e09a7af769-6c0828c3c2dso710085a34.1 for ; Mon, 04 Sep 2023 10:52:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1693849962; x=1694454762; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=/0NSux7WIhOlWENj4GY5q7z9ZP0dXuhkn2qOr3fP13A=; b=QaIBP9znXM3TctyOj8kvBWy+rIDx0BfOo5UnEfgmsAk4d2nj2SI1rtVq58h2jxDNKf h4Z+KPFfBi/ZA5zJD9wdY9vTS3rA2A+h4EQI4BcWKeoMkLxHnhSsIP5lAjv3/ykYUd89 6OATojQYY1ucWkNay56QxuAt/R+h8r7zSNpWx4nGdrWoB14Pq3rmICv/KB+C+bNUMgss x+KvMl5ijq0f6Mursb3306kmnVaUJzztfZKcLkhA/ZPmg9KJrFrnHQraMxs3+qXsZdvh iG7N0EN3wxuVM99hwddpuQnDmioPAvQE3yLh02m2qTzwRiZ7EADlRjtpYAwy0iYd72yb Pasw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693849962; x=1694454762; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/0NSux7WIhOlWENj4GY5q7z9ZP0dXuhkn2qOr3fP13A=; b=E3Wj9T2DFHYbybqJV6iCkK2Dt8dDqHKek6gtUN1t2entzK+oUs3ieitvhvHR0+et7W Q0kJWIlfMSjXjlV1QmDpd2gdmSlJB9Y2qyfQAyMHGiv8xzgTuszPF3x4/IZVmqchQ0x5 hCEQEl74iVqkIcZqbDgaitPjX/ohgAqsCPH2sVyiZqgXtqDViKz1eZ25yapaxPiQmqy7 DoyQlEtMvsuhJqRgR5OdMZxQgNs40KOFCceLK7hbhgWeXeMq1jovRJYMYEDapR3/ZtPy ViuCeuMgdr2e0ZL855Cw/dr6jUE4kV6VVjhPRxn2s3MC26LyMEkxRHAjl99WZcmz/nZb S1/A== X-Gm-Message-State: AOJu0Yx259PRzuK6I4pc9wG5ADbRB5zZ4/YjeKGarePqxIa3Xe4rIGB0 VH3H3UCM+n0jkrwVC+btDcsfBrWeJk6XXbA7Wzc= X-Google-Smtp-Source: AGHT+IE02hbyxClU0q+VLjVe/UVes00MtfmE3gI74NFN0LhTxB9sOC/Rue1sXT08bzG3eYxwjuSR8w== X-Received: by 2002:a9d:4818:0:b0:6bf:3f4:3edc with SMTP id c24-20020a9d4818000000b006bf03f43edcmr11297444otf.22.1693849962579; Mon, 04 Sep 2023 10:52:42 -0700 (PDT) Received: from x1 ([2601:1c2:1800:f680:e0eb:2a3d:8122:b588]) by smtp.gmail.com with ESMTPSA id gw8-20020a17090b0a4800b0025645ce761dsm9361371pjb.35.2023.09.04.10.52.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Sep 2023 10:52:41 -0700 (PDT) Date: Mon, 4 Sep 2023 10:52:39 -0700 From: Drew Fustini To: Xi Ruoyao Cc: Jisheng Zhang , Guo Ren , Fu Wei , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] riscv: dts: thead: set dma-noncoherent to soc bus Message-ID: References: <20230820115353.1962-1-jszhang@kernel.org> <292198d3915bafbe1c82372da2f2755a1842512f.camel@xry111.site> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <292198d3915bafbe1c82372da2f2755a1842512f.camel@xry111.site> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 05, 2023 at 12:28:41AM +0800, Xi Ruoyao wrote: > On Mon, 2023-09-04 at 22:45 +0800, Jisheng Zhang wrote: > > On Sun, Sep 03, 2023 at 04:32:21PM -0700, Drew Fustini wrote: > > > On Sun, Aug 20, 2023 at 07:53:53PM +0800, Jisheng Zhang wrote: > > > > riscv select ARCH_DMA_DEFAULT_COHERENT by default, and th1520 isn't > > > > dma coherent, so set dma-noncoherent to reflect this fact. > > > > > > > > Signed-off-by: Jisheng Zhang > > > > --- > > > >  arch/riscv/boot/dts/thead/th1520.dtsi | 1 + > > > >  1 file changed, 1 insertion(+) > > > > > > > > diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi > > > > index 56a73134b49e..58108f0eb3fd 100644 > > > > --- a/arch/riscv/boot/dts/thead/th1520.dtsi > > > > +++ b/arch/riscv/boot/dts/thead/th1520.dtsi > > > > @@ -139,6 +139,7 @@ soc { > > > >                 interrupt-parent = <&plic>; > > > >                 #address-cells = <2>; > > > >                 #size-cells = <2>; > > > > +               dma-noncoherent; > > > >                 ranges; > > > >   > > > >                 plic: interrupt-controller@ffd8000000 { > > > > -- > > > > 2.40.1 > > > > > > > > > > Tested-by: Drew Fustini > > > > > > I tried this on the BeagleV Ahead. They system booted as expected and I > > > did not notice any problems in the boot log. > > > > > > Are there other patches such as the dwmac series that I should test this > > > with? > > > > Hmm, this patch is necessary to test dwmac, emmc ;) > > Drew: does this fix the "broken DMA" issue you've mentioned in the EMMC > support patch? After I sent my reply yesterday, I then tried applying this patch on top of my eMMC series. I removed SDHCI_QUIRK_BROKEN_DMA and I discovered that SDMA did not immediately break and the mmcblk0 partitions appeared in /dev [1]. Note - I am using CONFIG_INITRAMFS_SOURCE set to my buidlroot rootfs.cpio so that the system will boot okay regardless of the emmc. I was able to mount the emmc boot partition /dev/mmcblk0p2. However, after unmounting it, I noticed that I could not mount it again: # mount /dev/mmcblk0p2 /mnt/p2 [ 41.684899] EXT4-fs (mmcblk0p2): mounted filesystem 6ea98ccf-2178-48a9-a1ad-0eb454f57268 r/w with ordered data mode # ls -la /mnt/p2 total 22696 drwxr-xr-x 5 root root 4096 Sep 4 2023 . drwxr-xr-x 4 root root 0 Jan 1 00:00 .. -rw-rw-r-- 1 1000 1000 26455552 Sep 4 2023 Image drwxr-xr-x 2 root root 4096 Jul 29 2023 extlinux # umount /mnt/p2 [ 52.101003] EXT4-fs (mmcblk0p2): unmounting filesystem 6ea98ccf-2178-48a9-a1ad-0eb454f57268. # mount /dev/mmcblk0p2 /mnt/p2 [ 58.826078] JBD2: no valid journal superblock found [ 58.831041] EXT4-fs (mmcblk0p2): Could not load journal inode mount: mounting /dev/mmcblk0p2 on /mnt/p2 failed: Invalid argument I was completely unable to mount the root fs partition /dev/mmcblk0p3: # mount /dev/mmcblk0p2 /mnt/p2 [ 58.826078] JBD2: no valid journal superblock found [ 58.831041] EXT4-fs (mmcblk0p2): Could not load journal inode mount: mounting /dev/mmcblk0p2 on /mnt/p2 failed: Invalid argument # umount /mnt/p2 umount: can't unmount /mnt/p2: Invalid argument I suspect there is some corruption of the buffers happening. I see there are also these patch series from Jisheng so I will try applying them and see if there is any difference: [PATCH v2 0/2] riscv: errata: improve T-Head CMO [PATCH] riscv: mm: update T-Head memory type definitions As for ADMA, when I removed SDHCI_QUIRK_BROKEN_ADMA, something fails silently [2] during boot and the mmcblk0 partitions do not appear under /dev. -Drew [1] https://gist.github.com/pdp7/6d27c57f8280fe1ae35e585d66e73f61 [2] https://gist.github.com/pdp7/23e2bcc2aba09b5c88eb579b61ea45ce