From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38A5FCA0FE2 for ; Tue, 5 Sep 2023 17:08:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353684AbjIERGY (ORCPT ); Tue, 5 Sep 2023 13:06:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354780AbjIEOTB (ORCPT ); Tue, 5 Sep 2023 10:19:01 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 937371AB for ; Tue, 5 Sep 2023 07:18:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to; s=k1; bh=d5oE VPZounkZyPqSJjsmtIRWD+j5ouluxyYTqoZnQ+s=; b=SfL2lb7f6vxDpXS15/8P 4L1xAOIHOiTnlsNiamQ3rD1s0zUp+7ntho7wHhZqury92ytZS3Uap6WRrwr9jmW4 g+k7q1okcnHEmagshZIAu2WiBWd8qqNcXdNxZ9GAd7uYLWcZ6zDtCWxfdYLnxxjM piJr8qLerL10kQhweg52r+9+ggZtk98QjEVzXpPSoGmC88bHARR0WGnUsNPlgFLl vHQ0VgrbSkFH+qs/GUSLORsrCihVD6mvu3eD0U5ur1Z/LTsad4AkX/2nLZUQTKEd bkf674LM7mZ22fc9kuKnjB78vDtljj8fWA+ph/B5TlTgelNSL6Mj/nhYkZKNK45r 2Q== Received: (qmail 2493423 invoked from network); 5 Sep 2023 16:18:53 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 5 Sep 2023 16:18:53 +0200 X-UD-Smtp-Session: l3s3148p1@g4JWTp0Ejt1ehhrI Date: Tue, 5 Sep 2023 16:18:50 +0200 From: Wolfram Sang To: Andi Shyti Cc: linux-renesas-soc@vger.kernel.org, Geert Uytterhoeven , Magnus Damm , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] i2c: rcar: introduce Gen4 devices Message-ID: Mail-Followup-To: Wolfram Sang , Andi Shyti , linux-renesas-soc@vger.kernel.org, Geert Uytterhoeven , Magnus Damm , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230904135852.12146-1-wsa+renesas@sang-engineering.com> <20230904135852.12146-3-wsa+renesas@sang-engineering.com> <20230905113624.5o2hfjojh3he7aex@zenone.zhora.eu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="N/d25QGf6h+4Nz7R" Content-Disposition: inline In-Reply-To: <20230905113624.5o2hfjojh3he7aex@zenone.zhora.eu> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --N/d25QGf6h+4Nz7R Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 05, 2023 at 01:36:24PM +0200, Andi Shyti wrote: > Hi Wolfram, >=20 > > @@ -1031,10 +1021,12 @@ static const struct of_device_id rcar_i2c_dt_id= s[] =3D { > > { .compatible =3D "renesas,i2c-r8a7794", .data =3D (void *)I2C_RCAR_G= EN2 }, > > { .compatible =3D "renesas,i2c-r8a7795", .data =3D (void *)I2C_RCAR_G= EN3 }, > > { .compatible =3D "renesas,i2c-r8a7796", .data =3D (void *)I2C_RCAR_G= EN3 }, > > + /* S4 has no FM+ bit */ > > + { .compatible =3D "renesas,i2c-r8a779f0", .data =3D (void *)I2C_RCAR_= GEN3 }, >=20 > is this I2C_RCAR_GEN3 or I2C_RCAR_GEN4? Technically, it is Gen4. But its I2C controller behaves like Gen3. This is why it has a seperate entry to avoid the generic Gen4 fallback... > > - { .compatible =3D "renesas,rcar-gen4-i2c", .data =3D (void *)I2C_RCAR= _GEN3 }, > > + { .compatible =3D "renesas,rcar-gen4-i2c", .data =3D (void *)I2C_RCAR= _GEN4 }, =2E.. here. --N/d25QGf6h+4Nz7R Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmT3OMYACgkQFA3kzBSg KbYaFg/9Fbrlwi3OToLBSRjgWHy76zRq9Q0XHUIwgaGhdHjUs+1rXuyWVaJhIsfb k3KFquWYNODEEJbTDTe6i2K+ZAXMPVuSDru1/ocZ1ksSuKiZvA510UjRRlNRHS0j W0jnvZJjt7FbLyERxZR51vu2LjqxW72MIb6LnAAjopk0606jhwkydMF5J68L1uZk 7fiGrNjPVzf09uKF7uqUQRPevp7m8b7h2P5lo9ng4qX+5o0ra8wzAcPxjt6bzhF4 MTL9YN41pMC86SwhNLSa5eVvvjh6nnYGgKgz3/lMRbfI1bfj10ZUoeKcdghmvdae Ca9+cXBZ7Db8xapXZWQ2sLF3NogORRgdMc1LLfJhUDrGGkvw4D2FIY2fqgIwKzV6 LCiQqzYKaJyhB55NvskrjqYMA7azGHlpN122oPxFobseeRUljvdmpUFY6Uc9Th3a 4aiy/Nzq2rLeLCbaBekxr5QDO2sec0PPZOA/FzowMzSJ8RoH2qGhyK1YUs6yv7EC YuN0Yg4b/NaGn05pu3tu2SWJwzH2mgKErQfmKUJWihJrFQNPreegVYxLK4bP3hOX 0EzGhr0nB5EsSQSfBJiy6uZSWaz9ciG+QP+NjtkBnDX86C9XGSD6gDI0EOTx951E rQLa1OGkeKQ5bfqP6jJJpHnNOj9pMlmRBgZjWV8JUit6J+/nm8E= =5g/h -----END PGP SIGNATURE----- --N/d25QGf6h+4Nz7R--