From: Andy Shevchenko <andy@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
"Rafael J . Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH] devres: rename the first parameter of devm_add_action_or_reset()
Date: Thu, 7 Sep 2023 17:07:27 +0300 [thread overview]
Message-ID: <ZPnZHzOli8w0Lqwr@smile.fi.intel.com> (raw)
In-Reply-To: <20230907110305.2096052-1-masahiroy@kernel.org>
On Thu, Sep 07, 2023 at 08:03:05PM +0900, Masahiro Yamada wrote:
> Fix a possible mistake in commit 410e7088e971 ("devres: Pass unique name
> of the resource to devm_add_action_or_reset()").
>
> The first parameter of devm_add_action_or_reset() is the associated
> device. The name 'release' is confusing because it is often used for
> dr_release_t in the devres context.
>
> Rename it to 'dev'. No functional change intended.
...
> -#define devm_add_action_or_reset(release, action, data) \
> - __devm_add_action_or_reset(release, action, data, #action)
> +#define devm_add_action_or_reset(dev, action, data) \
> + __devm_add_action_or_reset(dev, action, data, #action)
What about devm_add_action() and Co?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-09-07 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 11:03 [PATCH] devres: rename the first parameter of devm_add_action_or_reset() Masahiro Yamada
2023-09-07 14:07 ` Andy Shevchenko [this message]
2023-09-08 13:58 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPnZHzOli8w0Lqwr@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox