From: Petr Mladek <pmladek@suse.com>
To: Christoph Hellwig <hch@lst.de>
Cc: rostedt@goodmis.org, john.ogness@linutronix.de,
senozhatsky@chromium.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org,
Yunlong Xing <yunlong.xing@unisoc.com>,
enlinmu@gmail.com, yunlong.xing23@gmail.com
Subject: Re: [PATCH] Revert "printk: export symbols for debug modules"
Date: Fri, 8 Sep 2023 09:22:03 +0200 [thread overview]
Message-ID: <ZPrLm4fuSiv2-Rnm@alley> (raw)
In-Reply-To: <20230905132022.GA26718@lst.de>
On Tue 2023-09-05 15:20:22, Christoph Hellwig wrote:
> On Tue, Sep 05, 2023 at 11:54:37AM +0200, Petr Mladek wrote:
> > Yeah, I did not have a good feeling about this patch.
> >
> > I accepted it because there was an intention to upstream
> > the module, see
> > https://lore.kernel.org/all/CAAfh-jM0B2Cn579B0CkCrW44pJGGvjs112K+oMuViib+jDKafg@mail.gmail.com/
> >
> > I think that it was bad decision. We should not export
> > symbols when there is no in-tree user.
>
> I think raw address to the printk buffer is a bad idea even for an
> in-tree module.
Yeah, I suggested to use the kmsg_dump() API in the original thread.
Sigh, I made the bad decision in a hurry before vacation. I know
that it is a bad excuse but... Thanks for catching it.
Best Regards,
Petr
PS: I have just sent a pull request with the revert.
prev parent reply other threads:[~2023-09-08 7:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 8:19 [PATCH] Revert "printk: export symbols for debug modules" Christoph Hellwig
2023-09-05 8:22 ` Greg KH
2023-09-05 9:54 ` Petr Mladek
2023-09-05 13:20 ` Christoph Hellwig
2023-09-08 7:22 ` Petr Mladek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPrLm4fuSiv2-Rnm@alley \
--to=pmladek@suse.com \
--cc=enlinmu@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=yunlong.xing23@gmail.com \
--cc=yunlong.xing@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox