From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BA96EE57E2 for ; Fri, 8 Sep 2023 08:35:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238104AbjIHIf1 (ORCPT ); Fri, 8 Sep 2023 04:35:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232704AbjIHIf1 (ORCPT ); Fri, 8 Sep 2023 04:35:27 -0400 Received: from pandora.armlinux.org.uk (unknown [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41F8E173B; Fri, 8 Sep 2023 01:35:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=nlXYeDkgqdEWDoL9g1us3S9iH/v3r5oCkU5/ox/kGTs=; b=ExIYtBWMcLwufDORWjo+AhWUX/ MBg+qQEB0Ojx4Wz4w7uxeSbo/rxuNI70ZeCi31y4y1nMNlbzr+cMlFivk9aBg+nOdufsuBPZ/ApoK b9JLteaPz0zFJMVSwIak04Vo7WjKuk2sJZrzOJm4Al/906iy7DbisAI2Qs6zXg8zuIQU/9wPZnWFb pTBD6yrwBpcMefCdGt3cS5anLOLGiHcH7DLNx0qLvBfKJ7UXnhHABe4OpUW8L0wsrsgNP/vhWxf4n RINiib4ATxD7jCrhesfIuwPFeglcDihj+hN3lluToCC7/JR3Uy7wLfKXhA9qtB5nMw2UmK9KMmjOH SFbGJRjA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:35434) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qeWww-0004jT-1o; Fri, 08 Sep 2023 09:34:46 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qeWwv-0006jO-Li; Fri, 08 Sep 2023 09:34:45 +0100 Date: Fri, 8 Sep 2023 09:34:45 +0100 From: "Russell King (Oracle)" To: Puranjay Mohan Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Shubham Bansal , Mykola Lysenko , Shuah Khan , bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf-next v3 4/9] arm32, bpf: add support for unconditional bswap instruction Message-ID: References: <20230907230550.1417590-1-puranjay12@gmail.com> <20230907230550.1417590-5-puranjay12@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230907230550.1417590-5-puranjay12@gmail.com> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 07, 2023 at 11:05:45PM +0000, Puranjay Mohan wrote: > The cpuv4 added a new unconditional bswap instruction with following > behaviour: > > BPF_ALU64 | BPF_TO_LE | BPF_END with imm = 16/32/64 means: > dst = bswap16(dst) > dst = bswap32(dst) > dst = bswap64(dst) > > As we already support converting to big-endian from little-endian we can > use the same for unconditional bswap. just treat the unconditional scenario > the same as big-endian conversion. > > Signed-off-by: Puranjay Mohan Reviewed-by: Russell King (Oracle) Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!