From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 956DFCD4F49 for ; Fri, 22 Sep 2023 10:29:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232489AbjIVK3d (ORCPT ); Fri, 22 Sep 2023 06:29:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229532AbjIVK32 (ORCPT ); Fri, 22 Sep 2023 06:29:28 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D01C1CE for ; Fri, 22 Sep 2023 03:28:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695378515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ncEFTKmOctQzbh/NrWetlUFTCq9f4mLOYEczx2dd7dw=; b=UirEXNzdjhktRSI57kffnPxwB/2jYeZ07FArXzZviYBmaQlpsKYtP0dVdWNFcM3Sza9PgH gfBhHFCErpBuWhEUHucS0XASOfj8Z9bM6mFjQNP2xjOnPQlOJwbHD6VdZeS8ebQH911OaL NSLXtf2kMZ1Ud7aCFs+w1l70cxOIeDw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-196-8NF42pJKPOaI5Cuo1sMl-Q-1; Fri, 22 Sep 2023 06:28:32 -0400 X-MC-Unique: 8NF42pJKPOaI5Cuo1sMl-Q-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0545F803491; Fri, 22 Sep 2023 10:28:32 +0000 (UTC) Received: from localhost (unknown [10.72.112.35]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EC10371128F; Fri, 22 Sep 2023 10:28:30 +0000 (UTC) Date: Fri, 22 Sep 2023 18:28:27 +0800 From: Baoquan He To: "chenjiahao (C)" Cc: thunder.leizhen@huawei.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, conor.dooley@microchip.com, alexghiti@rivosinc.com, ajones@ventanamicro.com, jszhang@kernel.org, sunilvl@ventanamicro.com, robh@kernel.org, bjorn@rivosinc.com, zephray@outlook.com, akpm@linux-foundation.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] riscv: kdump: fix crashkernel reserving problem on RISC-V Message-ID: References: <20230922030722.708267-1-chenjiahao16@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/22/23 at 05:33pm, chenjiahao (C) wrote: > > On 2023/9/22 15:16, Baoquan He wrote: > > Hi Jiahao, > > > > On 09/22/23 at 11:07am, Chen Jiahao wrote: > > > When testing on risc-v QEMU environment with "crashkernel=" > > > parameter enabled, a problem occurred with the following > > > message: > > > > > > [ 0.000000] crashkernel low memory reserved: 0xf8000000 - 0x100000000 (128 MB) > > > [ 0.000000] crashkernel reserved: 0x0000000177e00000 - 0x0000000277e00000 (4096 MB) > > > [ 0.000000] ------------[ cut here ]------------ > > > [ 0.000000] WARNING: CPU: 0 PID: 0 at kernel/resource.c:779 __insert_resource+0x8e/0xd0 > > > [ 0.000000] Modules linked in: > > > [ 0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 6.6.0-rc2-next-20230920 #1 > > > [ 0.000000] Hardware name: riscv-virtio,qemu (DT) > > > [ 0.000000] epc : __insert_resource+0x8e/0xd0 > > > [ 0.000000] ra : insert_resource+0x28/0x4e > > > [ 0.000000] epc : ffffffff80017344 ra : ffffffff8001742e sp : ffffffff81203db0 > > > [ 0.000000] gp : ffffffff812ece98 tp : ffffffff8120dac0 t0 : ff600001f7ff2b00 > > > [ 0.000000] t1 : 0000000000000000 t2 : 3428203030303030 s0 : ffffffff81203dc0 > > > [ 0.000000] s1 : ffffffff81211e18 a0 : ffffffff81211e18 a1 : ffffffff81289380 > > > [ 0.000000] a2 : 0000000277dfffff a3 : 0000000177e00000 a4 : 0000000177e00000 > > > [ 0.000000] a5 : ffffffff81289380 a6 : 0000000277dfffff a7 : 0000000000000078 > > > [ 0.000000] s2 : ffffffff81289380 s3 : ffffffff80a0bac8 s4 : ff600001f7ff2880 > > > [ 0.000000] s5 : 0000000000000280 s6 : 8000000a00006800 s7 : 000000000000007f > > > [ 0.000000] s8 : 0000000080017038 s9 : 0000000080038ea0 s10: 0000000000000000 > > > [ 0.000000] s11: 0000000000000000 t3 : ffffffff80a0bc00 t4 : ffffffff80a0bc00 > > > [ 0.000000] t5 : ffffffff80a0bbd0 t6 : ffffffff80a0bc00 > > > [ 0.000000] status: 0000000200000100 badaddr: 0000000000000000 cause: 0000000000000003 > > > [ 0.000000] [] __insert_resource+0x8e/0xd0 > > > [ 0.000000] ---[ end trace 0000000000000000 ]--- > > > [ 0.000000] Failed to add a Crash kernel resource at 177e00000 > > > > > > The crashkernel memory has been allocated successfully, whereas > > > it failed to insert into iomem_resource. This is due to the > > This is a warning, not a failure, right? Inserting crashk_*res into > > iomem_resource has been successful, just the repeated inserting cause > > the warning. Maybe, we should tell this in log clearly? Other than minor > > concern, this looks good to me, thanks for the testing and this fix: > > Thanks for reviewing. Actually this is not only a warning message. > Since when failure occurs in riscv's init_resources(), > > error: > release_child_resources(&iomem_resource); > > will get called, already added crashkernel memory will hence > get removed. To verify this, I have checked but cannot find > crashkernel memory in /proc/iomem when this problem occurs. I see, I was mistaken then. Thanks for telling.