From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F4D4CE7A88 for ; Sat, 23 Sep 2023 09:03:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231317AbjIWJDO (ORCPT ); Sat, 23 Sep 2023 05:03:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231259AbjIWJDJ (ORCPT ); Sat, 23 Sep 2023 05:03:09 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DE29CC1 for ; Sat, 23 Sep 2023 02:02:04 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A854C433C9; Sat, 23 Sep 2023 09:01:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695459723; bh=1wubkG7ScgzJloOTfB6qo/zH9IOKqKxVD813hWAMOMk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RVwSdE+tm0lpxlsWqXhaGtF2ducIVr9x3cxZz3wj1JpSqVnElQJ2JluT7yRQq72qC In/LR+xCLTgdJ7GVOXWdq0pPVjp4DmxNLYW1wQ8rXMY+aBQfN8EHTTBo6pENBRU24u IyT8bUspR70T26/FHiAbnuSW7wRsQoOE1/CfjUbuMhSmuH+xwLZWpzjX7NB37uIkuI 29zgjWACFqp9ruPRugwyqA882HiME30/Payb0oZ0dyImZg2xupSPlOA5UAhg6iot38 m/uoO6xmxETVcYUx9nEywcM4pX1yGrx7+XVj1kP9dIhweVDWLxmYmab/kS+E8y8Pts 6nsleciA65S8g== Date: Sat, 23 Sep 2023 11:03:04 -0600 From: "Gustavo A. R. Silva" To: Kees Cook Cc: Andrew Morton , Shakeel Butt , Roman Gushchin , Johannes Weiner , Michal Hocko , "Matthew Wilcox (Oracle)" , Nathan Chancellor , Nick Desaulniers , Tom Rix , Yosry Ahmed , Yu Zhao , Miaohe Lin , Yafang Shao , Kefeng Wang , Qi Zheng , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org Subject: Re: [PATCH] mm/memcg: Annotate struct mem_cgroup_threshold_ary with __counted_by Message-ID: References: <20230922175327.work.985-kees@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230922175327.work.985-kees@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 22, 2023 at 10:53:28AM -0700, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct mem_cgroup_threshold_ary. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Andrew Morton > Cc: Shakeel Butt > Cc: Roman Gushchin > Cc: Johannes Weiner > Cc: Michal Hocko > Cc: "Matthew Wilcox (Oracle)" > Signed-off-by: Kees Cook Reviewed-by: Gustavo A. R. Silva Thanks -- Gustavo > --- > include/linux/memcontrol.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index 45d0c10e86cc..e0cfab58ab71 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -143,7 +143,7 @@ struct mem_cgroup_threshold_ary { > /* Size of entries[] */ > unsigned int size; > /* Array of thresholds */ > - struct mem_cgroup_threshold entries[]; > + struct mem_cgroup_threshold entries[] __counted_by(size); > }; > > struct mem_cgroup_thresholds { > -- > 2.34.1 > >