From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EE0DCE7A88 for ; Sat, 23 Sep 2023 09:03:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231223AbjIWJD6 (ORCPT ); Sat, 23 Sep 2023 05:03:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231364AbjIWJDa (ORCPT ); Sat, 23 Sep 2023 05:03:30 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E27CCD8; Sat, 23 Sep 2023 02:03:19 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B861C433C8; Sat, 23 Sep 2023 09:03:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695459798; bh=XWuqzQIj1H8eXCsv7k6yfzTfypuHPrX+X4bs0NkW8Sg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c1bGaH7waBdWEhB9tGkxARlXmv2I82G7hAGMnsAGEQZs4r3SQu8+f8XKXEEBHmzBl nUQiZSd7C5g4HMSHoRo5goJt0quD80GJOkKP45aIy1+cx/PZ4wcjpXIB5V5Dszy6X7 Up7NG1SWcK6B9JfqgIHEnx6mqN8Sw4WpGvtFujsRBFPLpAi/3biSWSqwdO2FHzD//y wrIW90fmE/a7Z121YhPrW4olrPH37nfxRKTrfYvkkA5LnFVTEfa9Ne7kva3knAqfgu SmoddciSNHlQ1Ur/Pp9mxvUmBbqAw6nab7WApbDMIm816Zt44VYgd0N2LnuKtTiBxl f0OjvjakKt2aQ== Date: Sat, 23 Sep 2023 11:04:21 -0600 From: "Gustavo A. R. Silva" To: Kees Cook Cc: Sebastian Reichel , Chen-Yu Tsai , linux-pm@vger.kernel.org, Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org Subject: Re: [PATCH] power: supply: axp20x_ac_power: Annotate struct axp20x_ac_power with __counted_by Message-ID: References: <20230922175355.work.006-kees@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230922175355.work.006-kees@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 22, 2023 at 10:53:55AM -0700, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct axp20x_ac_power. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Sebastian Reichel > Cc: Chen-Yu Tsai > Cc: linux-pm@vger.kernel.org > Signed-off-by: Kees Cook Reviewed-by: Gustavo A. R. Silva Thanks -- Gustavo > --- > drivers/power/supply/axp20x_ac_power.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/supply/axp20x_ac_power.c b/drivers/power/supply/axp20x_ac_power.c > index 19a118633115..e5733cb9e19e 100644 > --- a/drivers/power/supply/axp20x_ac_power.c > +++ b/drivers/power/supply/axp20x_ac_power.c > @@ -45,7 +45,7 @@ struct axp20x_ac_power { > struct iio_channel *acin_i; > bool has_acin_path_sel; > unsigned int num_irqs; > - unsigned int irqs[]; > + unsigned int irqs[] __counted_by(num_irqs); > }; > > static irqreturn_t axp20x_ac_power_irq(int irq, void *devid) > -- > 2.34.1 > >