Re: [RFT PATCH 3/3] gpio: eic-sprd: use devm_platform_ioremap_resource()

Andy Shevchenko
2023-09-12T10:38:21Z

On Tue, Sep 12, 2023 at 11:45:19AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Make two calls into one by using devm_platform_ioremap_resource().

...

> - res = platform_get_resource(pdev, IORESOURCE_MEM, i);
> - if (!res)
> - break;
> -
> - sprd_eic->base[i] = devm_ioremap_resource(dev, res);
> + sprd_eic->base[i] = devm_platform_ioremap_resource(pdev, i);
> if (IS_ERR(sprd_eic->base[i]))
> return PTR_ERR(sprd_eic->base[i]);

break != return

--
With Best Regards,
Andy Shevchenko