* [PATCH] [v2] ASoC: dwc: fix typo in comment
@ 2023-09-13 2:41 Myunguk Kim
2023-09-13 7:27 ` Bagas Sanjaya
2023-09-13 17:52 ` Mark Brown
0 siblings, 2 replies; 6+ messages in thread
From: Myunguk Kim @ 2023-09-13 2:41 UTC (permalink / raw)
To: alsa-devel
Cc: broonie, fido_max, kuninori.morimoto.gx, lgirdwood, linux-kernel,
perex, tiwai, u.kleine-koenig, xingyu.wu, mwkim
ISR_RXFO means "Status of Data Overrun interrupt for the RX channel"
according to the datasheet.
So, the comment should be RX, not TX
Signed-off-by: Myunguk Kim <mwkim@gaonchips.com>
---
sound/soc/dwc/dwc-i2s.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/dwc/dwc-i2s.c b/sound/soc/dwc/dwc-i2s.c
index 22c004179214..c71c17ef961d 100644
--- a/sound/soc/dwc/dwc-i2s.c
+++ b/sound/soc/dwc/dwc-i2s.c
@@ -138,7 +138,7 @@ static irqreturn_t i2s_irq_handler(int irq, void *dev_id)
irq_valid = true;
}
- /* Error Handling: TX */
+ /* Error Handling: RX */
if (isr[i] & ISR_RXFO)
{ dev_err_ratelimited(dev->dev, "RX overrun (ch_id=%d)\n", i);
irq_valid = true;
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] [v2] ASoC: dwc: fix typo in comment
2023-09-13 2:41 [PATCH] [v2] ASoC: dwc: fix typo in comment Myunguk Kim
@ 2023-09-13 7:27 ` Bagas Sanjaya
2023-09-13 17:52 ` Mark Brown
1 sibling, 0 replies; 6+ messages in thread
From: Bagas Sanjaya @ 2023-09-13 7:27 UTC (permalink / raw)
To: Myunguk Kim, alsa-devel
Cc: broonie, fido_max, kuninori.morimoto.gx, lgirdwood, linux-kernel,
perex, tiwai, u.kleine-koenig, xingyu.wu
[-- Attachment #1: Type: text/plain, Size: 1105 bytes --]
On Wed, Sep 13, 2023 at 11:41:04AM +0900, Myunguk Kim wrote:
> ISR_RXFO means "Status of Data Overrun interrupt for the RX channel"
> according to the datasheet.
>
> So, the comment should be RX, not TX
Thanks for better description!
The patch title though, I'd like to write it as "ASoC: dwc: correct ISR_RXFO
check comment".
>
> Signed-off-by: Myunguk Kim <mwkim@gaonchips.com>
> ---
> sound/soc/dwc/dwc-i2s.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/dwc/dwc-i2s.c b/sound/soc/dwc/dwc-i2s.c
> index 22c004179214..c71c17ef961d 100644
> --- a/sound/soc/dwc/dwc-i2s.c
> +++ b/sound/soc/dwc/dwc-i2s.c
> @@ -138,7 +138,7 @@ static irqreturn_t i2s_irq_handler(int irq, void *dev_id)
> irq_valid = true;
> }
>
> - /* Error Handling: TX */
> + /* Error Handling: RX */
> if (isr[i] & ISR_RXFO)
> { dev_err_ratelimited(dev->dev, "RX overrun (ch_id=%d)\n", i);
> irq_valid = true;
In any case,
Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] [v2] ASoC: dwc: fix typo in comment
2023-09-13 2:41 [PATCH] [v2] ASoC: dwc: fix typo in comment Myunguk Kim
2023-09-13 7:27 ` Bagas Sanjaya
@ 2023-09-13 17:52 ` Mark Brown
2023-09-14 0:56 ` Myunguk Kim
1 sibling, 1 reply; 6+ messages in thread
From: Mark Brown @ 2023-09-13 17:52 UTC (permalink / raw)
To: Myunguk Kim
Cc: alsa-devel, fido_max, kuninori.morimoto.gx, lgirdwood,
linux-kernel, perex, tiwai, u.kleine-koenig, xingyu.wu
[-- Attachment #1: Type: text/plain, Size: 557 bytes --]
On Wed, Sep 13, 2023 at 11:41:04AM +0900, Myunguk Kim wrote:
> ISR_RXFO means "Status of Data Overrun interrupt for the RX channel"
> according to the datasheet.
>
> So, the comment should be RX, not TX
This patch still doesn't apply:
>
> - /* Error Handling: TX */
> + /* Error Handling: RX */
> if (isr[i] & ISR_RXFO)
> { dev_err_ratelimited(dev->dev, "RX overrun (ch_id=%d)\n", i);
The patch is obviously corrupted, the { there should be on the prior
line and even fixing that by hand there appear to be some other issues.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] [v2] ASoC: dwc: fix typo in comment
2023-09-13 17:52 ` Mark Brown
@ 2023-09-14 0:56 ` Myunguk Kim
2023-09-14 6:32 ` Uwe Kleine-König
0 siblings, 1 reply; 6+ messages in thread
From: Myunguk Kim @ 2023-09-14 0:56 UTC (permalink / raw)
To: broonie
Cc: alsa-devel, fido_max, kuninori.morimoto.gx, lgirdwood,
linux-kernel, mwkim, perex, tiwai, u.kleine-koenig, xingyu.wu
> The patch is obviously corrupted, the { there should be on the prior
> line and even fixing that by hand there appear to be some other issues.
The patch file should have been attached as shown below.
Is there a problem with my git send-email?
---
sound/soc/dwc/dwc-i2s.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/dwc/dwc-i2s.c b/sound/soc/dwc/dwc-i2s.c
index 22c004179214..c71c17ef961d 100644
--- a/sound/soc/dwc/dwc-i2s.c
+++ b/sound/soc/dwc/dwc-i2s.c
@@ -138,7 +138,7 @@ static irqreturn_t i2s_irq_handler(int irq, void *dev_id)
irq_valid = true;
}
- /* Error Handling: TX */
+ /* Error Handling: RX */
if (isr[i] & ISR_RXFO)
{ dev_err_ratelimited(dev->dev, "RX overrun (ch_id=%d)\n", i);
irq_valid = true;
--
Thanks,
myunguk
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] [v2] ASoC: dwc: fix typo in comment
2023-09-14 0:56 ` Myunguk Kim
@ 2023-09-14 6:32 ` Uwe Kleine-König
2023-09-14 11:42 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Uwe Kleine-König @ 2023-09-14 6:32 UTC (permalink / raw)
To: Myunguk Kim
Cc: broonie, alsa-devel, fido_max, kuninori.morimoto.gx, lgirdwood,
linux-kernel, perex, tiwai, xingyu.wu
[-- Attachment #1: Type: text/plain, Size: 1257 bytes --]
On Thu, Sep 14, 2023 at 09:56:34AM +0900, Myunguk Kim wrote:
> > The patch is obviously corrupted, the { there should be on the prior
> > line and even fixing that by hand there appear to be some other issues.
>
> The patch file should have been attached as shown below.
> Is there a problem with my git send-email?
>
> ---
> sound/soc/dwc/dwc-i2s.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/dwc/dwc-i2s.c b/sound/soc/dwc/dwc-i2s.c
> index 22c004179214..c71c17ef961d 100644
> --- a/sound/soc/dwc/dwc-i2s.c
> +++ b/sound/soc/dwc/dwc-i2s.c
> @@ -138,7 +138,7 @@ static irqreturn_t i2s_irq_handler(int irq, void *dev_id)
> irq_valid = true;
> }
>
> - /* Error Handling: TX */
> + /* Error Handling: RX */
> if (isr[i] & ISR_RXFO)
> { dev_err_ratelimited(dev->dev, "RX overrun (ch_id=%d)\n", i);
> irq_valid = true;
FTR: I get this mail directly (so no mailing list server involved), and
the patch is mangled in the same way as broonie pointed out in his mail
earlier in this thread.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] [v2] ASoC: dwc: fix typo in comment
2023-09-14 6:32 ` Uwe Kleine-König
@ 2023-09-14 11:42 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2023-09-14 11:42 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Myunguk Kim, alsa-devel, fido_max, kuninori.morimoto.gx,
lgirdwood, linux-kernel, perex, tiwai, xingyu.wu
[-- Attachment #1: Type: text/plain, Size: 817 bytes --]
On Thu, Sep 14, 2023 at 08:32:48AM +0200, Uwe Kleine-König wrote:
> On Thu, Sep 14, 2023 at 09:56:34AM +0900, Myunguk Kim wrote:
> > > The patch is obviously corrupted, the { there should be on the prior
> > > line and even fixing that by hand there appear to be some other issues.
> > The patch file should have been attached as shown below.
> > Is there a problem with my git send-email?
> > + /* Error Handling: RX */
> > if (isr[i] & ISR_RXFO)
> > { dev_err_ratelimited(dev->dev, "RX overrun (ch_id=%d)\n", i);
> FTR: I get this mail directly (so no mailing list server involved), and
> the patch is mangled in the same way as broonie pointed out in his mail
> earlier in this thread.
Right, same here. I don't know where the problem might be, it's not a
pattern I've seen before.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-09-14 11:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-13 2:41 [PATCH] [v2] ASoC: dwc: fix typo in comment Myunguk Kim
2023-09-13 7:27 ` Bagas Sanjaya
2023-09-13 17:52 ` Mark Brown
2023-09-14 0:56 ` Myunguk Kim
2023-09-14 6:32 ` Uwe Kleine-König
2023-09-14 11:42 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox