From: Ingo Molnar <mingo@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Justin Stitt <justinstitt@google.com>,
Steve Wahl <steve.wahl@hpe.com>,
Mike Travis <mike.travis@hpe.com>,
Dimitri Sivanich <dimitri.sivanich@hpe.com>,
Russ Anderson <russ.anderson@hpe.com>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v3] x86/platform/uv: refactor deprecated strcpy and strncpy
Date: Thu, 14 Sep 2023 08:30:30 +0200 [thread overview]
Message-ID: <ZQKohp0plVd4S5St@gmail.com> (raw)
In-Reply-To: <953f2e40-7b0e-27b5-b017-a1ac2175bb47@redhat.com>
* Hans de Goede <hdegoede@redhat.com> wrote:
> >> Which IMHO is much more readable then what has landed now. But since
> >> v2 has already landed I guess the best thing is just to stick with
> >> what we have upstream now...
> >
> > Well, how about we do a delta patch with all the changes you suggested?
> > I'm all for readability.
>
> So I started doing this and notices that all the string manipulation +
> parsing done here is really just a DYI implementation of
> sysfs_match_string().
>
> So I have prepared a patch to switch to sysfs_match_string(), which
> completely removes the need to make a copy of the val string.
>
> I'll submit the patch right after this email.
Thank you - that looks a far more thorough cleanup indeed.
Ingo
prev parent reply other threads:[~2023-09-14 6:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 21:54 [PATCH v3] x86/platform/uv: refactor deprecated strcpy and strncpy Justin Stitt
2023-09-06 11:42 ` Hans de Goede
2023-09-06 12:10 ` Ingo Molnar
2023-09-06 12:16 ` Hans de Goede
2023-09-06 13:30 ` Andy Shevchenko
2023-09-06 14:09 ` Ingo Molnar
2023-09-06 15:07 ` Steve Wahl
2023-09-13 15:12 ` Hans de Goede
2023-09-14 6:30 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQKohp0plVd4S5St@gmail.com \
--to=mingo@kernel.org \
--cc=andy@infradead.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dimitri.sivanich@hpe.com \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=hpa@zytor.com \
--cc=justinstitt@google.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.travis@hpe.com \
--cc=mingo@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=russ.anderson@hpe.com \
--cc=steve.wahl@hpe.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox