From: Brian Foster <bfoster@redhat.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: kent.overstreet@linux.dev, linux-bcachefs@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH 9/9] bcachefs: Modify mismatched function name
Date: Thu, 14 Sep 2023 08:18:42 -0400 [thread overview]
Message-ID: <ZQL6ItDgXFgJyU+M@bfoster> (raw)
In-Reply-To: <20230914090457.32325-1-jiapeng.chong@linux.alibaba.com>
On Thu, Sep 14, 2023 at 05:04:49PM +0800, Jiapeng Chong wrote:
> No functional modification involved.
>
> fs/bcachefs/alloc_foreground.c:514: warning: expecting prototype for bch_bucket_alloc(). Prototype was for bch2_bucket_alloc_trans() instead.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6584
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
JFYI, it seems like the patch series is oddly threaded with patch 9/9
being the "cover letter..?"
Also, what's the granularity of the patches here? Per robot filed bug?
Per source file? I don't think it really matters for this particular
series, though personally I would probably squash these down into one
upon merge (and prefer to see any further patches of this nature
similarly condensed).
Brian
> fs/bcachefs/alloc_foreground.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/bcachefs/alloc_foreground.c b/fs/bcachefs/alloc_foreground.c
> index e02749ddc362..10a7979707ef 100644
> --- a/fs/bcachefs/alloc_foreground.c
> +++ b/fs/bcachefs/alloc_foreground.c
> @@ -502,7 +502,7 @@ static struct open_bucket *bch2_bucket_alloc_freelist(struct btree_trans *trans,
> }
>
> /**
> - * bch_bucket_alloc - allocate a single bucket from a specific device
> + * bch2_bucket_alloc_trans - allocate a single bucket from a specific device
> *
> * Returns index of bucket on success, 0 on failure
> */
> --
> 2.20.1.7.g153144c
>
next prev parent reply other threads:[~2023-09-14 12:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 9:04 [PATCH 9/9] bcachefs: Modify mismatched function name Jiapeng Chong
2023-09-14 9:04 ` [PATCH 1/9] " Jiapeng Chong
2023-09-14 9:04 ` [PATCH 2/9] " Jiapeng Chong
2023-09-14 9:04 ` [PATCH 3/9] " Jiapeng Chong
2023-09-14 9:04 ` [PATCH 4/9] " Jiapeng Chong
2023-09-14 9:04 ` [PATCH 5/9] " Jiapeng Chong
2023-09-14 9:04 ` [PATCH 6/9] " Jiapeng Chong
2023-09-14 9:04 ` [PATCH 7/9] " Jiapeng Chong
2023-09-14 9:04 ` [PATCH 8/9] " Jiapeng Chong
2023-09-14 12:18 ` Brian Foster [this message]
2023-09-14 19:49 ` [PATCH 9/9] " Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQL6ItDgXFgJyU+M@bfoster \
--to=bfoster@redhat.com \
--cc=abaci@linux.alibaba.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox