From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB11FCD37BC for ; Sat, 16 Sep 2023 10:30:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238929AbjIPK1n (ORCPT ); Sat, 16 Sep 2023 06:27:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234989AbjIPK1K (ORCPT ); Sat, 16 Sep 2023 06:27:10 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D55FCEC for ; Sat, 16 Sep 2023 03:27:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694860025; x=1726396025; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=NpYRpck12yRE0afPagiZhDKRlGxV/J6TEPLL4JmygBU=; b=DzIgKbtRbrEpwsHadt0ZTCBi/7S5+nhtOYSBEUARLGN30GSGz6/9vb1K Ebd8NJmingtt/N33w1sB7mFaTwZTwxfemiznlGx+i1OdgDA+NZ4HVbEMG OjmS5e4fk6BrJ4TXWdQyfzvecLosEATiVa0wyPNWhb0ZNoMVgxoioS+q0 C3Tem6Z4jhG4x4ZGTwRn4hsb7uD9sGuegtx5Idyshs0Ja7RMP+1wPHBhC 1dFM3M+XwCnIUfny6NBYi95HR/DEEtjz90b2+twYxisWYV5tWVnicN2TP /CoJg13OqE4UZENNVf5OQ/Zp4R1qe7po+8gtZOm19CYRrKYaoOqU9qDJI Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10834"; a="410358060" X-IronPort-AV: E=Sophos;i="6.02,152,1688454000"; d="scan'208";a="410358060" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2023 03:25:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10834"; a="695000890" X-IronPort-AV: E=Sophos;i="6.02,152,1688454000"; d="scan'208";a="695000890" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga003.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2023 03:24:59 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC0) (envelope-from ) id 1qhSTw-0000000F5fe-4AzJ; Sat, 16 Sep 2023 13:24:56 +0300 Date: Sat, 16 Sep 2023 13:24:56 +0300 From: Andy Shevchenko To: Huacai Chen Cc: loongarch@lists.linux.dev, linux-kernel@vger.kernel.org, WANG Xuerui Subject: Re: [PATCH v1 1/2] LoongArch: Add missing headers Message-ID: References: <20230914103445.511285-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 15, 2023 at 08:36:24AM +0800, Huacai Chen wrote: > On Fri, Sep 15, 2023 at 2:53 AM Andy Shevchenko > wrote: > > On Thu, Sep 14, 2023 at 11:25:22PM +0800, Huacai Chen wrote: > > > Thank you for your patch, can this patch solve the problem below? > > > https://lore.kernel.org/oe-kbuild-all/202309072237.9zxMv4MZ-lkp@intel.com/T/#u > > > > Nope, this just adds missing includes. > > No functional change, so warnings will still be there. > But I think a patch should solve a problem. No, that problem is static analyser concern, not the compiler nor linker. > If we don't get a build > error or warning without this patch, does that mean the 'missing' > headers are actually included indirectly? I might be missing something, but I do not see any build error in the above message. -- With Best Regards, Andy Shevchenko