From: Ingo Molnar <mingo@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [GIT PULL] objtool fix
Date: Sun, 17 Sep 2023 19:34:13 +0200 [thread overview]
Message-ID: <ZQc4lawqy8NnDzys@gmail.com> (raw)
Linus,
Please pull the latest objtool/urgent git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git objtool-urgent-2023-09-17
# HEAD: 72178d5d1a38dd185d1db15f177f2d122ef10d9b objtool: Fix _THIS_IP_ detection for cold functions
Fix a cold functions related false-positive objtool warning
that triggers on Clang.
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Thanks,
Ingo
------------------>
Josh Poimboeuf (1):
objtool: Fix _THIS_IP_ detection for cold functions
tools/objtool/check.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index 1384090530db..e308d1ba664e 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -4333,7 +4333,8 @@ static int validate_ibt_insn(struct objtool_file *file, struct instruction *insn
continue;
}
- if (insn_func(dest) && insn_func(dest) == insn_func(insn)) {
+ if (insn_func(dest) && insn_func(insn) &&
+ insn_func(dest)->pfunc == insn_func(insn)->pfunc) {
/*
* Anything from->to self is either _THIS_IP_ or
* IRET-to-self.
next reply other threads:[~2023-09-17 17:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-17 17:34 Ingo Molnar [this message]
2023-09-17 18:24 ` [GIT PULL] objtool fix pr-tracker-bot
-- strict thread matches above, loose matches on Subject: below --
2025-11-01 7:08 Ingo Molnar
2025-11-01 17:41 ` pr-tracker-bot
2024-12-29 8:55 Ingo Molnar
2024-12-29 18:22 ` pr-tracker-bot
2023-01-12 13:57 Ingo Molnar
2023-01-12 23:01 ` pr-tracker-bot
2020-12-27 9:31 Ingo Molnar
2020-12-27 17:27 ` pr-tracker-bot
2017-10-14 15:53 Ingo Molnar
2017-02-02 20:50 Ingo Molnar
2016-12-07 18:40 Ingo Molnar
2016-10-28 8:30 Ingo Molnar
2016-06-10 12:01 Ingo Molnar
2016-05-25 20:10 Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQc4lawqy8NnDzys@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox