From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v3 07/11] gpiolib: replace find_chip_by_name() with gpio_device_find_by_label()
Date: Mon, 18 Sep 2023 10:22:53 +0300 [thread overview]
Message-ID: <ZQf6zTsoZDFaIgHO@smile.fi.intel.com> (raw)
In-Reply-To: <20230915150327.81918-8-brgl@bgdev.pl>
On Fri, Sep 15, 2023 at 05:03:22PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Remove all remaining uses of find_chip_by_name() (and subsequently:
> gpiochip_find()) from gpiolib.c and use the new
> gpio_device_find_by_label() instead.
...
> -static int gpiochip_match_name(struct gpio_chip *gc, void *data)
> -{
> - const char *name = data;
> -
> - return !strcmp(gc->label, name);
And this we had no check for the label being NULL...
...
> for (p = &table->table[0]; p->key; p++) {
> + struct gpio_device *gdev __free(gpio_device_put) = NULL;
> + gdev = gpio_device_find_by_label(p->key);
> + if (!gdev) {
I haven't got the fix for gpio-sim, shouldn't we have the same here, i.e.
definition being done together with the assignment when __free() is in use?
> }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-09-18 7:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 15:03 [PATCH v3 00/11] gpiolib: work towards removing gpiochip_find() Bartosz Golaszewski
2023-09-15 15:03 ` [PATCH v3 01/11] gpiolib: make gpio_device_get() and gpio_device_put() public Bartosz Golaszewski
2023-09-15 15:03 ` [PATCH v3 02/11] gpiolib: add support for scope-based management to gpio_device Bartosz Golaszewski
2023-09-15 15:03 ` [PATCH v3 03/11] gpiolib: provide gpio_device_find() Bartosz Golaszewski
2023-09-15 15:03 ` [PATCH v3 04/11] gpiolib: provide gpio_device_find_by_label() Bartosz Golaszewski
2023-09-18 7:19 ` Andy Shevchenko
2023-09-27 11:22 ` Bartosz Golaszewski
2023-09-27 12:33 ` Andy Shevchenko
2023-09-27 12:42 ` Bartosz Golaszewski
2023-09-27 13:48 ` Andy Shevchenko
2023-09-27 13:57 ` Bartosz Golaszewski
2023-09-15 15:03 ` [PATCH v3 05/11] gpiolib: provide gpio_device_get_desc() Bartosz Golaszewski
2023-09-15 15:03 ` [PATCH v3 06/11] gpiolib: reluctantly provide gpio_device_get_chip() Bartosz Golaszewski
2023-09-15 15:03 ` [PATCH v3 07/11] gpiolib: replace find_chip_by_name() with gpio_device_find_by_label() Bartosz Golaszewski
2023-09-18 7:22 ` Andy Shevchenko [this message]
2023-09-18 8:03 ` Bartosz Golaszewski
2023-09-20 9:01 ` Linus Walleij
2023-09-15 15:03 ` [PATCH v3 08/11] gpio: of: replace gpiochip_find_* with gpio_device_find_* Bartosz Golaszewski
2023-09-15 15:03 ` [PATCH v3 09/11] gpio: acpi: replace gpiochip_find() with gpio_device_find() Bartosz Golaszewski
2023-09-18 5:29 ` Mika Westerberg
2023-09-15 15:03 ` [PATCH v3 10/11] gpio: swnode: replace gpiochip_find() with gpio_device_find_by_label() Bartosz Golaszewski
2023-09-18 7:25 ` Andy Shevchenko
2023-09-18 8:04 ` Bartosz Golaszewski
2023-09-15 15:03 ` [PATCH v3 11/11] gpio: sysfs: drop the mention of gpiochip_find() from sysfs code Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQf6zTsoZDFaIgHO@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox