From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Charles Han <hanchunchao@inspur.com>, <corbet@lwn.net>,
<djwong@kernel.org>, <dchinner@redhat.com>,
<allison.henderson@oracle.com>, <bhelgaas@google.com>
Cc: <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/1] Documentation: xfs: Remove duplicate 'the' in transaction sequence process
Date: Mon, 18 Sep 2023 15:03:45 +0700 [thread overview]
Message-ID: <ZQgEYU71YE6Jv38D@debian.me> (raw)
In-Reply-To: <20230918074054.313204-1-hanchunchao@inspur.com>
[-- Attachment #1: Type: text/plain, Size: 1621 bytes --]
On Mon, Sep 18, 2023 at 03:40:54PM +0800, Charles Han wrote:
> Remove the repeated word "the" in comments.
Patch title looks OK but in this case, the patch description should also match.
Hint: there is no code comments in the doc below.
>
> Signed-off-by: Charles Han <hanchunchao@inspur.com>
> ---
> Documentation/filesystems/xfs-online-fsck-design.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/xfs-online-fsck-design.rst b/Documentation/filesystems/xfs-online-fsck-design.rst
> index 1625d1131093..a0678101a7d0 100644
> --- a/Documentation/filesystems/xfs-online-fsck-design.rst
> +++ b/Documentation/filesystems/xfs-online-fsck-design.rst
> @@ -1585,7 +1585,7 @@ The transaction sequence looks like this:
> 2. The second transaction contains a physical update to the free space btrees
> of AG 3 to release the former BMBT block and a second physical update to the
> free space btrees of AG 7 to release the unmapped file space.
> - Observe that the the physical updates are resequenced in the correct order
> + Observe that the physical updates are resequenced in the correct order
> when possible.
> Attached to the transaction is a an extent free done (EFD) log item.
> The EFD contains a pointer to the EFI logged in transaction #1 so that log
Regardless, wait for one or few days before rerolling this patch with
reviews addressed. It allows other reviewers to catch up and review. You can
also Cc: me if you'd like.
See you in v3!
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-09-18 8:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 7:40 [PATCH v2 1/1] Documentation: xfs: Remove duplicate 'the' in transaction sequence process Charles Han
2023-09-18 8:03 ` Bagas Sanjaya [this message]
2023-09-18 8:14 ` Jonathan Corbet
2023-09-18 9:07 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQgEYU71YE6Jv38D@debian.me \
--to=bagasdotme@gmail.com \
--cc=allison.henderson@oracle.com \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=hanchunchao@inspur.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox