From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39336CD3423 for ; Mon, 18 Sep 2023 08:05:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240577AbjIRIFJ (ORCPT ); Mon, 18 Sep 2023 04:05:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240634AbjIRIEk (ORCPT ); Mon, 18 Sep 2023 04:04:40 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBE59E55; Mon, 18 Sep 2023 01:04:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695024242; x=1726560242; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=IOZ5ST0b115tZcGqcBmYtjTOXXLGsl37rzvNJdPtNrQ=; b=bl2sQZq4uXKYMUkzNg4evqfgSI/op5RzCKhuW1OTKi5iCY2xoOSfHECJ +twNAiSINxaeK/dhqFRZr25S2PpLzGe2aRGWHC6/UuOEhuO1fRNv0Qyvo uGTsgIb++mZZ6H3PHn2wGoVmm/fAwMzF6oeT/rNIKPFuw8l6b3XrRlIVA bfTdJKyen1pVhVPEsS6OeTZMTUtmoNExSIf7F9dwpxJshODmLjxTdCIpX aOmV+/MURSxTWQSLWiCFKk6K1s1s0vXKqEmj7I50xOkoUuIaIjs3s341c 8fNpDHeipY0E5mi/Y1TNe9HoMDD7cdACfsNct3ZN1+M/ymtJkKYrg+Rpz w==; X-IronPort-AV: E=McAfee;i="6600,9927,10836"; a="443670758" X-IronPort-AV: E=Sophos;i="6.02,156,1688454000"; d="scan'208";a="443670758" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2023 01:04:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10836"; a="992621087" X-IronPort-AV: E=Sophos;i="6.02,156,1688454000"; d="scan'208";a="992621087" Received: from kuha.fi.intel.com ([10.237.72.185]) by fmsmga006.fm.intel.com with SMTP; 18 Sep 2023 01:03:58 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Mon, 18 Sep 2023 11:03:57 +0300 Date: Mon, 18 Sep 2023 11:03:57 +0300 From: Heikki Krogerus To: "Patel, Utkarsh H" Cc: Prashant Malani , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , "chrome-platform@lists.linux.dev" , "andriy.shevchenko@linux.intel.com" , "bleung@chromium.org" Subject: Re: [PATCH v3 3/4] platform/chrome: cros_ec_typec: Add Displayport Alternatemode 2.1 Support Message-ID: References: <20230912005752.1532888-1-utkarsh.h.patel@intel.com> <20230912005752.1532888-4-utkarsh.h.patel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 15, 2023 at 04:01:44PM +0000, Patel, Utkarsh H wrote: > > > b057250704e8..3a747938cdab 100644 > > > --- a/include/linux/usb/pd_vdo.h > > > +++ b/include/linux/usb/pd_vdo.h > > > @@ -376,6 +376,7 @@ > > > | ((vbm) & 0x3) << 9 | (sbu) << 8 | (sbut) << 7 | ((cur) & 0x3) << 5 \ > > > | (vbt) << 4 | (sopp) << 3 | ((spd) & 0x7)) > > > > > > +#define VDO_TYPEC_CABLE_SPEED(vdo) ((vdo) & 0x7) > > > > I would suggest putting this header modification in a separate patch; if for > > some reason we have to revert the Chrome part of the change, then we won't > > rip this part out too (some other driver down the road may use the macro and > > would break if it were to be removed). But I'll leave it to Heikki to determine > > whether that is preferred. > > > Heikki, What's your preference here? I think separate patch for this like Prashant said. thanks, -- heikki