From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51410CD13D9 for ; Mon, 18 Sep 2023 16:06:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230049AbjIRQGL (ORCPT ); Mon, 18 Sep 2023 12:06:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229926AbjIRQGE (ORCPT ); Mon, 18 Sep 2023 12:06:04 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F5C230DD; Mon, 18 Sep 2023 09:05:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695053114; x=1726589114; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=xUKO1lA8xYmCgJHL6wMNL16CXTAfwplxErKfnHb19GI=; b=f1i6XjRvUTd3EiAj/632XiBuujLOiU6CwE3rfX6xJv0zvlh1ovP4iRCa 5T2PjGPdWbjm6KjONegS5CJGE8p4U4iV648hFc4fhHkp4b8oKvaKHizxZ pZAg8didG0TZZEjlBO1rOuOj+d+wsADtwHRSEavTWM4D7HhPG1N40LZqB f9TUEtwJNWXfS3KzBTdLVYcTLi+ttJTRq9i3fu1ACAbSxlxe4Ib04hkMg SeffLr0mMNQ7xsjxIq+vxrM9srWO7Ue+QZH6E1Hst9V7lXz41ltqeEaq8 4PVvzFGjcdDD1h0UelZa9Rq71pFdpA/wxFr3uf+9xuVDvU5GU6hsZ8S4H Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10837"; a="382417277" X-IronPort-AV: E=Sophos;i="6.02,156,1688454000"; d="scan'208";a="382417277" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2023 07:26:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10837"; a="749040284" X-IronPort-AV: E=Sophos;i="6.02,156,1688454000"; d="scan'208";a="749040284" Received: from kuha.fi.intel.com ([10.237.72.185]) by fmsmga007.fm.intel.com with SMTP; 18 Sep 2023 07:26:13 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Mon, 18 Sep 2023 17:26:12 +0300 Date: Mon, 18 Sep 2023 17:26:12 +0300 From: Heikki Krogerus To: Prashanth K Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "# 5 . 16" Subject: Re: usb: typec: ucsi: Clear EVENT_PENDING bit if ucsi_send_command fails Message-ID: References: <1694423055-8440-1-git-send-email-quic_prashk@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1694423055-8440-1-git-send-email-quic_prashk@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 11, 2023 at 02:34:15PM +0530, Prashanth K wrote: > Currently if ucsi_send_command() fails, then we bail out without > clearing EVENT_PENDING flag. So when the next connector change > event comes, ucsi_connector_change() won't queue the con->work, > because of which none of the new events will be processed. > > Fix this by clearing EVENT_PENDING flag if ucsi_send_command() > fails. > > Cc: # 5.16 > Fixes: 512df95b9432 ("usb: typec: ucsi: Better fix for missing unplug events issue") > Signed-off-by: Prashanth K Acked-by: Heikki Krogerus > --- > drivers/usb/typec/ucsi/ucsi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c > index c6dfe3d..509c67c 100644 > --- a/drivers/usb/typec/ucsi/ucsi.c > +++ b/drivers/usb/typec/ucsi/ucsi.c > @@ -884,6 +884,7 @@ static void ucsi_handle_connector_change(struct work_struct *work) > if (ret < 0) { > dev_err(ucsi->dev, "%s: GET_CONNECTOR_STATUS failed (%d)\n", > __func__, ret); > + clear_bit(EVENT_PENDING, &con->ucsi->flags); > goto out_unlock; > } > thanks, -- heikki