From: Sasha Levin <sashal@kernel.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Pavel Machek <pavel@denx.de>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Kent Overstreet <kent.overstreet@linux.dev>,
linux-block@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 6.1 20/22] block: Allow bio_iov_iter_get_pages() with bio->bi_bdev unset
Date: Mon, 18 Sep 2023 16:57:55 -0400 [thread overview]
Message-ID: <ZQi50xT1o/N2o8Bt@sashalap> (raw)
In-Reply-To: <d6da7de6-e603-4fb3-b68e-8d919f26fefe@kernel.dk>
On Mon, Sep 11, 2023 at 07:15:18AM -0600, Jens Axboe wrote:
>On 9/11/23 3:54 AM, Pavel Machek wrote:
>> Hi!
>>
>>> From: Kent Overstreet <kent.overstreet@linux.dev>
>>>
>>> [ Upstream commit 168145f617d57bf4e474901b7ffa869337a802e6 ]
>>>
>>> bio_iov_iter_get_pages() trims the IO based on the block size of the
>>> block device the IO will be issued to.
>>>
>>> However, bcachefs is a multi device filesystem; when we're creating the
>>> bio we don't yet know which block device the bio will be submitted to -
>>> we have to handle the alignment checks elsewhere.
>>>
>>> Thus this is needed to avoid a null ptr deref.
>>
>> We are certainly not going to backport bcachefs to -stable. Please
>> drop.
>
>I already said as much 3 days ago:
>
>https://lore.kernel.org/all/cd341326-cfaf-4796-8894-2241e7b630d9@kernel.dk/
>
>but didn't hear back yet.
Dropped, and sorry for lack of timely replies on this - I let them
collect feedback for a few weeks before going through it and dropping
what needs to be dropped.
--
Thanks,
Sasha
next prev parent reply other threads:[~2023-09-18 20:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 19:33 [PATCH AUTOSEL 6.1 01/22] drm/bridge: tc358762: Instruct DSI host to generate HSE packets Sasha Levin
2023-09-08 19:33 ` [PATCH AUTOSEL 6.1 02/22] drm/edid: Add quirk for OSVR HDK 2.0 Sasha Levin
2023-09-08 19:33 ` [PATCH AUTOSEL 6.1 03/22] arm64: dts: qcom: sm6125-pdx201: correct ramoops pmsg-size Sasha Levin
2023-09-08 19:33 ` [PATCH AUTOSEL 6.1 04/22] arm64: dts: qcom: sm6350: " Sasha Levin
2023-09-08 19:33 ` [PATCH AUTOSEL 6.1 05/22] arm64: dts: qcom: sm8150-kumano: " Sasha Levin
2023-09-08 19:33 ` [PATCH AUTOSEL 6.1 06/22] arm64: dts: qcom: sm8250-edo: " Sasha Levin
2023-09-08 19:33 ` [PATCH AUTOSEL 6.1 07/22] samples/hw_breakpoint: Fix kernel BUG 'invalid opcode: 0000' Sasha Levin
2023-09-08 19:33 ` [PATCH AUTOSEL 6.1 08/22] drm/amd/display: Read down-spread percentage from lut to adjust dprefclk Sasha Levin
2023-09-08 19:33 ` [PATCH AUTOSEL 6.1 09/22] drm/amd/display: Fix underflow issue on 175hz timing Sasha Levin
2023-09-08 19:33 ` [PATCH AUTOSEL 6.1 10/22] drm/vkms: Fix race-condition between the hrtimer and the atomic commit Sasha Levin
2023-09-08 19:33 ` [PATCH AUTOSEL 6.1 11/22] ASoC: SOF: topology: simplify code to prevent static analysis warnings Sasha Levin
2023-09-08 19:33 ` [PATCH AUTOSEL 6.1 12/22] ASoC: Intel: sof_sdw: Update BT offload config for soundwire config Sasha Levin
2023-09-08 19:33 ` [PATCH AUTOSEL 6.1 13/22] ALSA: hda: intel-dsp-cfg: add LunarLake support Sasha Levin
2023-09-08 19:33 ` [PATCH AUTOSEL 6.1 14/22] drm/amd/display: Use DTBCLK as refclk instead of DPREFCLK Sasha Levin
2023-09-08 19:33 ` [PATCH AUTOSEL 6.1 15/22] drm/amd/display: Blocking invalid 420 modes on HDMI TMDS for DCN31 Sasha Levin
2023-09-08 19:34 ` [PATCH AUTOSEL 6.1 16/22] drm/amd/display: Blocking invalid 420 modes on HDMI TMDS for DCN314 Sasha Levin
2023-09-08 19:34 ` [PATCH AUTOSEL 6.1 17/22] drm/exynos: fix a possible null-pointer dereference due to data race in exynos_drm_crtc_atomic_disable() Sasha Levin
2023-09-08 19:34 ` [PATCH AUTOSEL 6.1 18/22] drm/mediatek: dp: Change logging to dev for mtk_dp_aux_transfer() Sasha Levin
2023-09-11 9:53 ` Pavel Machek
2023-09-08 19:34 ` [PATCH AUTOSEL 6.1 19/22] bus: ti-sysc: Configure uart quirks for k3 SoC Sasha Levin
2023-09-08 19:34 ` [PATCH AUTOSEL 6.1 20/22] block: Allow bio_iov_iter_get_pages() with bio->bi_bdev unset Sasha Levin
2023-09-11 9:54 ` Pavel Machek
2023-09-11 13:15 ` Jens Axboe
2023-09-18 20:57 ` Sasha Levin [this message]
2023-09-08 19:34 ` [PATCH AUTOSEL 6.1 21/22] md: raid1: fix potential OOB in raid1_remove_disk() Sasha Levin
2023-09-08 19:34 ` [PATCH AUTOSEL 6.1 22/22] ext2: fix datatype of block number in ext2_xattr_set2() Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQi50xT1o/N2o8Bt@sashalap \
--to=sashal@kernel.org \
--cc=axboe@kernel.dk \
--cc=kent.overstreet@linux.dev \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@denx.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox