From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79314CD4938 for ; Thu, 21 Sep 2023 01:41:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229753AbjIUBlI (ORCPT ); Wed, 20 Sep 2023 21:41:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229734AbjIUBlH (ORCPT ); Wed, 20 Sep 2023 21:41:07 -0400 Received: from Atcsqr.andestech.com (60-248-80-70.hinet-ip.hinet.net [60.248.80.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FBC8AF for ; Wed, 20 Sep 2023 18:41:00 -0700 (PDT) Received: from mail.andestech.com (ATCPCS16.andestech.com [10.0.1.222]) by Atcsqr.andestech.com with ESMTP id 38L1euGt010650; Thu, 21 Sep 2023 09:40:56 +0800 (+08) (envelope-from peterlin@andestech.com) Received: from APC323 (10.0.12.98) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.498.0; Thu, 21 Sep 2023 09:40:54 +0800 Date: Thu, 21 Sep 2023 09:40:51 +0800 From: Yu-Chien Peter Lin To: Conor Dooley CC: , , , , , , , , Subject: Re: [PATCH v3 1/3] riscv: Improve PTDUMP to show RSW with non-zero value Message-ID: References: <20230920035522.3180558-1-peterlin@andestech.com> <20230920-pureblood-unwilling-f17aff1eef6a@wendy> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230920-pureblood-unwilling-f17aff1eef6a@wendy> User-Agent: Mutt/2.2.10 (2023-03-25) X-Originating-IP: [10.0.12.98] X-DNSRBL: X-MAIL: Atcsqr.andestech.com 38L1euGt010650 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Conor, On Wed, Sep 20, 2023 at 10:55:30AM +0100, Conor Dooley wrote: > On Wed, Sep 20, 2023 at 11:55:20AM +0800, Yu Chien Peter Lin wrote: > > RSW field can be used to encode 2 bits of software > > defined information. Currently, PTDUMP only prints > > "RSW" when its value is 1 or 3. > > > > To fix this issue and improve the debugging experience > > with PTDUMP, we redefine _PAGE_SPECIAL to its original > > value and use _PAGE_SOFT as the RSW mask, allow it to > > print the RSW with any non-zero value. > > > > This patch also removes the val from the struct prot_bits > > as it is no longer needed. > > > > Could you please add cover letters to multi-patch patchsets? > > Thanks, > Conor. Sure, will do. Regards, Peter Lin