public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Pieralisi <lpieralisi@kernel.org>
To: Marc Zyngier <maz@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	Mark Rutland <mark.rutland@arm.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Fang Xiang <fangxiang3@xiaomi.com>
Subject: Re: [PATCH v2 0/2] irqchip/gic-v3: Enable non-coherent GIC designs probing
Date: Thu, 21 Sep 2023 12:11:39 +0200	[thread overview]
Message-ID: <ZQwW286bqB8dE2XN@lpieralisi> (raw)
In-Reply-To: <ZPhhMvyx8lChHE0v@lpieralisi>

On Wed, Sep 06, 2023 at 01:23:30PM +0200, Lorenzo Pieralisi wrote:
> On Wed, Sep 06, 2023 at 10:52:01AM +0100, Marc Zyngier wrote:
> > On 2023-09-06 10:41, Lorenzo Pieralisi wrote:
> > > This series is v2 of a previous version[1].
> > > 
> > > v1 -> v2:
> > > 	- Updated DT bindings as per feedback
> > > 	- Updated patch[2] to use GIC quirks infrastructure
> > > 
> > > [1]
> > > https://lore.kernel.org/all/20230905104721.52199-1-lpieralisi@kernel.org
> > > 
> > > Original cover letter
> > > ---
> > > The GICv3 architecture specifications provide a means for the
> > > system programmer to set the shareability and cacheability
> > > attributes the GIC components (redistributors and ITSes) use
> > > to drive memory transactions.
> > > 
> > > Albeit the architecture give control over shareability/cacheability
> > > memory transactions attributes (and barriers), it is allowed to
> > > connect the GIC interconnect ports to non-coherent memory ports
> > > on the interconnect, basically tying off shareability/cacheability
> > > "wires" and de-facto making the redistributors and ITSes non-coherent
> > > memory observers.
> > > 
> > > This series aims at starting a discussion over a possible solution
> > > to this problem, by adding to the GIC device tree bindings the
> > > standard dma-noncoherent property. The GIC driver uses the property
> > > to force the redistributors and ITSes shareability attributes to
> > > non-shareable, which consequently forces the driver to use CMOs
> > > on GIC memory tables.
> > > 
> > > On ARM DT DMA is default non-coherent, so the GIC driver can't rely
> > > on the generic DT dma-coherent/non-coherent property management layer
> > > (of_dma_is_coherent()) which would default all GIC designs in the field
> > > as non-coherent; it has to rely on ad-hoc dma-noncoherent property
> > > handling.
> > > 
> > > When a consistent approach is agreed upon for DT an equivalent binding
> > > will
> > > be put forward for ACPI based systems.
> > 
> > What is the plan for this last point? I'd like to see at least
> > a proposal before taking this series in.
> 
> Absolutely, I am starting a thread on related MADT changes, should not
> take too long.

Quick update, bindings filed, I will code against it but we should
not merge anything till it is approved (could be missing v6.7 timeline).

https://bugzilla.tianocore.org/show_bug.cgi?id=4557

Lorenzo

  reply	other threads:[~2023-09-21 21:34 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-05 10:47 [PATCH 0/2] irqchip/gic-v3: Enable non-coherent GIC designs probing Lorenzo Pieralisi
2023-09-05 10:47 ` [PATCH 1/2] dt-bindings: interrupt-controller: arm,gic-v3: Add dma-noncoherent property Lorenzo Pieralisi
2023-09-05 11:17   ` Robin Murphy
2023-09-05 12:22     ` Lorenzo Pieralisi
2023-09-05 12:57       ` Robin Murphy
2023-09-05 18:23   ` Rob Herring
2023-09-05 10:47 ` [PATCH 2/2] irqchip/gic-v3: Enable non-coherent redistributors/ITSes probing Lorenzo Pieralisi
2023-09-05 11:34   ` Marc Zyngier
2023-09-05 12:14     ` Robin Murphy
2023-09-05 12:30     ` Lorenzo Pieralisi
2023-09-05 12:41       ` Marc Zyngier
2023-09-05 14:24     ` Lorenzo Pieralisi
2023-09-05 14:34       ` Marc Zyngier
2023-09-06 11:01       ` Fang Xiang
2023-10-03 14:43     ` Lorenzo Pieralisi
2023-10-03 16:18       ` Robin Murphy
2023-10-03 16:44       ` Marc Zyngier
2023-10-04  7:13         ` Lorenzo Pieralisi
2023-10-05 13:59         ` Lorenzo Pieralisi
2023-09-06  9:41 ` [PATCH v2 0/2] irqchip/gic-v3: Enable non-coherent GIC designs probing Lorenzo Pieralisi
2023-09-06  9:41   ` [PATCH v2 1/2] dt-bindings: interrupt-controller: arm,gic-v3: Add dma-noncoherent property Lorenzo Pieralisi
2023-09-06 11:23     ` Rob Herring
2023-09-06 11:27     ` Lorenzo Pieralisi
2023-09-06  9:41   ` [PATCH v2 2/2] irqchip/gic-v3: Enable non-coherent redistributors/ITSes probing Lorenzo Pieralisi
2023-09-06  9:52   ` [PATCH v2 0/2] irqchip/gic-v3: Enable non-coherent GIC designs probing Marc Zyngier
2023-09-06 11:23     ` Lorenzo Pieralisi
2023-09-21 10:11       ` Lorenzo Pieralisi [this message]
2023-10-06 12:59 ` [PATCH v3 0/5] " Lorenzo Pieralisi
2023-10-06 12:59   ` [PATCH v3 1/5] dt-bindings: interrupt-controller: arm,gic-v3: Add dma-noncoherent property Lorenzo Pieralisi
2023-10-07 12:00     ` [irqchip: irq/irqchip-fixes] " irqchip-bot for Lorenzo Pieralisi
2023-10-06 12:59   ` [PATCH v3 2/5] irqchip/gic-v3: Enable non-coherent redistributors/ITSes DT probing Lorenzo Pieralisi
2023-10-07 12:00     ` [irqchip: irq/irqchip-fixes] " irqchip-bot for Lorenzo Pieralisi
2023-10-06 12:59   ` [PATCH v3 3/5] irqchip/gic-v3-its: Split allocation from initialisation of its_node Lorenzo Pieralisi
2023-10-07 12:00     ` [irqchip: irq/irqchip-fixes] " irqchip-bot for Marc Zyngier
2023-10-24  8:48     ` [PATCH v3 3/5] " Dominic Rath
2023-10-24 10:18       ` Marc Zyngier
2023-10-24 13:13         ` Dominic Rath
2023-10-25 19:51       ` [tip: irq/urgent] irqchip/gic-v3-its: Don't override quirk settings with default values tip-bot2 for Marc Zyngier
2023-10-06 12:59   ` [PATCH v3 4/5] ACPICA: Add new MADT GICC/GICR/ITS flags handling [code first] Lorenzo Pieralisi
2023-10-06 12:59   ` [PATCH v3 5/5] irqchip/gic-v3: Enable non-coherent redistributors/ITSes ACPI probing Lorenzo Pieralisi
2023-10-17 14:19     ` Lorenzo Pieralisi
2023-10-17 16:44       ` Marc Zyngier
2023-10-18  8:42         ` Lorenzo Pieralisi
2023-10-19 11:12           ` Marc Zyngier
2023-12-27 11:00 ` [PATCH v4 0/3] irqchip/gic-v3: Enable non-coherent GIC designs probing Lorenzo Pieralisi
2023-12-27 11:00   ` [PATCH v4 1/3] ACPICA: MADT: Add GICC online capable bit handling Lorenzo Pieralisi
2024-01-09 14:27     ` Rafael J. Wysocki
2023-12-27 11:00   ` [PATCH v4 2/3] ACPICA: MADT: Add new MADT GICC/GICR/ITS non-coherent flags handling Lorenzo Pieralisi
2023-12-27 11:00   ` [PATCH v4 3/3] irqchip/gic-v3: Enable non-coherent redistributors/ITSes ACPI probing Lorenzo Pieralisi
2024-01-04 11:12     ` Marc Zyngier
2024-01-08  9:43       ` Lorenzo Pieralisi
2024-01-08  9:52         ` Marc Zyngier
2024-01-22 16:18     ` Lorenzo Pieralisi
2024-01-22 18:27       ` Marc Zyngier
2024-01-03 13:43   ` [PATCH v4 0/3] irqchip/gic-v3: Enable non-coherent GIC designs probing Rafael J. Wysocki
2024-01-04 11:34     ` Marc Zyngier
2024-01-04 12:04       ` Russell King (Oracle)
2024-01-04 13:21         ` Rafael J. Wysocki
2024-01-04 13:47           ` Russell King (Oracle)
2024-01-08  9:45           ` Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZQwW286bqB8dE2XN@lpieralisi \
    --to=lpieralisi@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fangxiang3@xiaomi.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox