Re: [PATCH 1/6] serial: 8250: remove AR7 support

Jiri Slaby
2023-09-21T18:36:09Z

On 21. 09. 23, 13:16, Andy Shevchenko wrote:
> On Thu, Sep 21, 2023 at 12:36:05PM +0200, Philippe Mathieu-Daudé wrote:
>> On 20/9/23 22:10, Wolfram Sang wrote:
>
>>> --- a/include/uapi/linux/serial_core.h
>>> +++ b/include/uapi/linux/serial_core.h
>>> @@ -32,7 +32,6 @@
>>> #define PORT_XSCALE 15
>>> #define PORT_RM9000 16 /* PMC-Sierra RM9xxx internal UART */
>>> #define PORT_OCTEON 17 /* Cavium OCTEON internal UART */
>>> -#define PORT_AR7 18 /* Texas Instruments AR7 internal UART */
>>
>> I'm a bit surprised definitions are removed from the uAPI, isn't
>> it expected to be very stable? Shouldn't it be better to keep it
>> defined but modify the comment, mentioning "obsolete" or "deprecated"?
>
> The numbers up to 20 must stay, they are being used somewhere, setserial
> implementation in busybox (IIRC).

But they define it if we don't:
#ifndef PORT_AR7
# define PORT_AR7 18
#endif

> NAK.
I don't mind either way. But likely we should reserve the field if we go
and remove it (setserial has a number->string mapping in busybox). Hm,
then reserving it or keep it? Perhaps keep it is better... So ack the
NACK :).

--
js
suse labs