From: Andy Shevchenko <andy@kernel.org>
To: Wenhua Lin <Wenhua.Lin@unisoc.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
wenhua lin <wenhua.lin1994@gmail.com>,
Xiongpeng Wu <xiongpeng.wu@unisoc.com>
Subject: Re: [PATCH V2 3/4] gpio: sprd: Modify the calculation method of eic number
Date: Thu, 21 Sep 2023 14:27:20 +0300 [thread overview]
Message-ID: <ZQwomPRn0HaqHMgK@smile.fi.intel.com> (raw)
In-Reply-To: <20230921090027.11136-4-Wenhua.Lin@unisoc.com>
On Thu, Sep 21, 2023 at 05:00:26PM +0800, Wenhua Lin wrote:
> When the soc changes, the corresponding gpio-eic-sprd.c
> code needs to be modified, and the corresponding
> Document must also be modified, which is quite troublesome.
> To avoid modifying the driver file, the number of EICs
> is automatically calculated by matching dts nodes.
> Fixes: 2788938b7946 ("gpio: eic-sprd: Make the irqchip immutable")
>
> Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com>
Same comment as per patch 1. Also, fixes needs to be grouped at the beginning
of the series. (I don't remember seeing Fixes tag in the patch 2.)
...
> +#define SPRD_EIC_VAR_DATA(soc_name) \
Misindented \
> +static const struct sprd_eic_variant_data soc_name##_eic_dbnc_data = { \
> + .type = SPRD_EIC_DEBOUNCE, \
> +}; \
...
> struct sprd_eic *sprd_eic;
> struct resource *res;
> int ret, i;
> + u16 num_banks = 0;
Preserve reversed xmas tree order.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-09-21 17:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 9:00 [PATCH V2 0/4] gpio: sprd: Modification of UNISOC Platform EIC Driver Wenhua Lin
2023-09-21 9:00 ` [PATCH V2 1/4] gpio: sprd: In the sleep state, the eic debounce clk must be forced open Wenhua Lin
2023-09-21 11:23 ` Andy Shevchenko
2024-01-02 8:34 ` wenhua lin
2023-09-27 9:08 ` Baolin Wang
2024-01-02 8:42 ` wenhua lin
2023-09-21 9:00 ` [PATCH V2 2/4] gpio: sprd: Clear interrupt after set the interrupt type Wenhua Lin
2023-09-21 11:24 ` Andy Shevchenko
2024-01-03 12:06 ` wenhua lin
2023-09-27 9:15 ` Baolin Wang
2023-09-21 9:00 ` [PATCH V2 3/4] gpio: sprd: Modify the calculation method of eic number Wenhua Lin
2023-09-21 11:27 ` Andy Shevchenko [this message]
2024-01-04 2:31 ` wenhua lin
2023-09-27 9:24 ` Baolin Wang
2024-01-03 12:04 ` wenhua lin
2023-09-21 9:00 ` [PATCH V2 4/4] gpio: sprd: Support 8 banks EIC controller Wenhua Lin
2023-09-27 9:28 ` Baolin Wang
2024-01-03 12:03 ` wenhua lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQwomPRn0HaqHMgK@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=Wenhua.Lin@unisoc.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=wenhua.lin1994@gmail.com \
--cc=xiongpeng.wu@unisoc.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox